From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-pci@vger.kernel.org, linux-kbuild@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Michal Marek <mmarek@suse.cz>,
Kumar Gala <galak@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 8/9] powerpc: move PCI fixup hooks from __init to __devinit
Date: Wed, 06 Jun 2012 15:28:00 +1000 [thread overview]
Message-ID: <1338960480.7150.161.camel@pasglop> (raw)
In-Reply-To: <1338749305-22558-9-git-send-email-sebastian@breakpoint.cc>
On Sun, 2012-06-03 at 20:48 +0200, Sebastian Andrzej Siewior wrote:
> The fixups are executed once the pci-device is found which is during
> boot process so __init seems fine as long as the platform does not
> support hotplug.
> However it is possible to remove the PCI bus at run time and have it
> rediscovered again via "echo 1 > /sys/bus/pci/rescan" and this will call
> the fixups again.
>
> Cc: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Thanks !
Ben.
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> ---
> arch/powerpc/platforms/85xx/tqm85xx.c | 2 +-
> arch/powerpc/platforms/86xx/gef_ppc9a.c | 2 +-
> arch/powerpc/platforms/86xx/gef_sbc310.c | 2 +-
> arch/powerpc/platforms/86xx/gef_sbc610.c | 2 +-
> arch/powerpc/sysdev/fsl_pci.c | 2 +-
> arch/powerpc/sysdev/mv64x60_pci.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/platforms/85xx/tqm85xx.c b/arch/powerpc/platforms/85xx/tqm85xx.c
> index 4d786c2..3e70a20 100644
> --- a/arch/powerpc/platforms/85xx/tqm85xx.c
> +++ b/arch/powerpc/platforms/85xx/tqm85xx.c
> @@ -102,7 +102,7 @@ static void tqm85xx_show_cpuinfo(struct seq_file *m)
> seq_printf(m, "PLL setting\t: 0x%x\n", ((phid1 >> 24) & 0x3f));
> }
>
> -static void __init tqm85xx_ti1520_fixup(struct pci_dev *pdev)
> +static void __devinit tqm85xx_ti1520_fixup(struct pci_dev *pdev)
> {
> unsigned int val;
>
> diff --git a/arch/powerpc/platforms/86xx/gef_ppc9a.c b/arch/powerpc/platforms/86xx/gef_ppc9a.c
> index 1fca663..563aafa8 100644
> --- a/arch/powerpc/platforms/86xx/gef_ppc9a.c
> +++ b/arch/powerpc/platforms/86xx/gef_ppc9a.c
> @@ -164,7 +164,7 @@ static void gef_ppc9a_show_cpuinfo(struct seq_file *m)
> gef_ppc9a_get_vme_is_syscon() ? "yes" : "no");
> }
>
> -static void __init gef_ppc9a_nec_fixup(struct pci_dev *pdev)
> +static void __devinit gef_ppc9a_nec_fixup(struct pci_dev *pdev)
> {
> unsigned int val;
>
> diff --git a/arch/powerpc/platforms/86xx/gef_sbc310.c b/arch/powerpc/platforms/86xx/gef_sbc310.c
> index 14e0e576..cc6a91a 100644
> --- a/arch/powerpc/platforms/86xx/gef_sbc310.c
> +++ b/arch/powerpc/platforms/86xx/gef_sbc310.c
> @@ -152,7 +152,7 @@ static void gef_sbc310_show_cpuinfo(struct seq_file *m)
>
> }
>
> -static void __init gef_sbc310_nec_fixup(struct pci_dev *pdev)
> +static void __devinit gef_sbc310_nec_fixup(struct pci_dev *pdev)
> {
> unsigned int val;
>
> diff --git a/arch/powerpc/platforms/86xx/gef_sbc610.c b/arch/powerpc/platforms/86xx/gef_sbc610.c
> index 1638f43..aead6b3 100644
> --- a/arch/powerpc/platforms/86xx/gef_sbc610.c
> +++ b/arch/powerpc/platforms/86xx/gef_sbc610.c
> @@ -141,7 +141,7 @@ static void gef_sbc610_show_cpuinfo(struct seq_file *m)
> seq_printf(m, "SVR\t\t: 0x%x\n", svid);
> }
>
> -static void __init gef_sbc610_nec_fixup(struct pci_dev *pdev)
> +static void __devinit gef_sbc610_nec_fixup(struct pci_dev *pdev)
> {
> unsigned int val;
>
> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
> index 6073288..edbf794 100644
> --- a/arch/powerpc/sysdev/fsl_pci.c
> +++ b/arch/powerpc/sysdev/fsl_pci.c
> @@ -36,7 +36,7 @@
>
> static int fsl_pcie_bus_fixup, is_mpc83xx_pci;
>
> -static void __init quirk_fsl_pcie_header(struct pci_dev *dev)
> +static void __devinit quirk_fsl_pcie_header(struct pci_dev *dev)
> {
> u8 progif;
>
> diff --git a/arch/powerpc/sysdev/mv64x60_pci.c b/arch/powerpc/sysdev/mv64x60_pci.c
> index b0037ce..364b14d 100644
> --- a/arch/powerpc/sysdev/mv64x60_pci.c
> +++ b/arch/powerpc/sysdev/mv64x60_pci.c
> @@ -104,7 +104,7 @@ subsys_initcall(mv64x60_sysfs_init);
>
> #endif /* CONFIG_SYSFS */
>
> -static void __init mv64x60_pci_fixup_early(struct pci_dev *dev)
> +static void __devinit mv64x60_pci_fixup_early(struct pci_dev *dev)
> {
> /*
> * Set the host bridge hdr_type to an invalid value so that
next prev parent reply other threads:[~2012-06-06 5:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 18:48 Annotate PCI fixups with __devinit instead of __init Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 1/9] scripts/modpost: check for bad refernces in .pci.fixups area Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 2/9] x86/quirks: move PCI fixup hooks from __init to __devinit Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 3/9] pci/quirks: " Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 4/9] alpha: " Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 5/9] arm: " Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 6/9] frv: " Sebastian Andrzej Siewior
2012-06-03 18:48 ` [PATCH 7/9] mips: " Sebastian Andrzej Siewior
2012-06-14 16:39 ` Myron Stowe
2012-06-15 16:33 ` Bjorn Helgaas
2012-06-15 16:38 ` Ralf Baechle
2012-06-15 21:13 ` Bjorn Helgaas
2012-06-16 8:50 ` Sebastian Andrzej Siewior
2012-06-16 18:45 ` Bjorn Helgaas
2012-06-03 18:48 ` [PATCH 8/9] powerpc: " Sebastian Andrzej Siewior
2012-06-06 5:28 ` Benjamin Herrenschmidt [this message]
2012-06-03 18:48 ` [PATCH 9/9] sh: " Sebastian Andrzej Siewior
2012-06-04 1:12 ` Annotate PCI fixups with __devinit instead of __init Bjorn Helgaas
2012-06-12 1:27 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338960480.7150.161.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=paulus@samba.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).