From: Huang Ying <ying.huang@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: ming.m.lin@intel.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Huang Ying <ying.huang@intel.com>,
Zheng Yan <zheng.z.yan@intel.com>,
Michal Miroslaw <mirq-linux@rere.qmqm.pl>,
Jesse Barnes <jesse.barnes@intel.com>
Subject: [PATCH -v7 3/4] PCI, do not call pci_set_power_state with PCI_D3cold
Date: Sat, 23 Jun 2012 10:23:50 +0800 [thread overview]
Message-ID: <1340418231-10134-4-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1340418231-10134-1-git-send-email-ying.huang@intel.com>
PCI subsystem has not been ready for D3cold support yet. So
PCI_D3cold should not be used as parameter for pci_set_power_state.
This patch is needed for upcoming PCI_D3cold support.
This patch has no functionality change, because pci_set_power_state
will bound the parameter to PCI_D3hot too.
Cc: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Cc: Jesse Barnes <jesse.barnes@intel.com>
Signed-off-by: Huang Ying <ying.huang@intel.com>
Reviewed-by: Rafael J. Wysocki <rjw@sisk.pl>
---
arch/x86/pci/mrst.c | 2 +-
drivers/misc/cb710/core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/arch/x86/pci/mrst.c
+++ b/arch/x86/pci/mrst.c
@@ -264,7 +264,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
static void __devinit mrst_power_off_unused_dev(struct pci_dev *dev)
{
- pci_set_power_state(dev, PCI_D3cold);
+ pci_set_power_state(dev, PCI_D3hot);
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0801, mrst_power_off_unused_dev);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0809, mrst_power_off_unused_dev);
--- a/drivers/misc/cb710/core.c
+++ b/drivers/misc/cb710/core.c
@@ -180,7 +180,7 @@ static int cb710_suspend(struct pci_dev
pci_save_state(pdev);
pci_disable_device(pdev);
if (state.event & PM_EVENT_SLEEP)
- pci_set_power_state(pdev, PCI_D3cold);
+ pci_set_power_state(pdev, PCI_D3hot);
return 0;
}
next prev parent reply other threads:[~2012-06-23 2:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 2:23 [PATCH -v7 0/4] PCIe, PM, Add PCIe runtime D3cold support Huang Ying
2012-06-23 2:23 ` [PATCH -v7 1/4] ACPI, PM, Specify lowest allowed state for device sleep state Huang Ying
2012-06-23 2:23 ` [PATCH -v7 2/4] PCIe, PM, Add runtime PM support to PCIe port Huang Ying
2012-06-23 2:23 ` Huang Ying [this message]
2012-06-23 2:23 ` [PATCH -v7 4/4] PCIe, PM, Add PCIe runtime D3cold support Huang Ying
2012-06-23 21:26 ` [PATCH -v7 0/4] " Bjorn Helgaas
2012-06-24 2:47 ` huang ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340418231-10134-4-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=bhelgaas@google.com \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=rjw@sisk.pl \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).