From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 3/5] PCI, acpiphp: Merge acpiphp_debug and debug
Date: Sat, 23 Jun 2012 00:42:03 -0700 [thread overview]
Message-ID: <1340437325-29282-4-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1340437325-29282-1-git-send-email-yinghai@kernel.org>
Should not have two, just remove debug, and use module_param_named
instead.
Also change acpiphp_debug to bool.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/hotplug/acpiphp.h | 2 +-
drivers/pci/hotplug/acpiphp_core.c | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
index 6b58ed0..a1afb5b 100644
--- a/drivers/pci/hotplug/acpiphp.h
+++ b/drivers/pci/hotplug/acpiphp.h
@@ -205,6 +205,6 @@ extern u8 acpiphp_get_latch_status (struct acpiphp_slot *slot);
extern u8 acpiphp_get_adapter_status (struct acpiphp_slot *slot);
/* variables */
-extern int acpiphp_debug;
+extern bool acpiphp_debug;
#endif /* _ACPIPHP_H */
diff --git a/drivers/pci/hotplug/acpiphp_core.c b/drivers/pci/hotplug/acpiphp_core.c
index aa41631..96316b7 100644
--- a/drivers/pci/hotplug/acpiphp_core.c
+++ b/drivers/pci/hotplug/acpiphp_core.c
@@ -47,8 +47,7 @@
/* name size which is used for entries in pcihpfs */
#define SLOT_NAME_SIZE 21 /* {_SUN} */
-static bool debug;
-int acpiphp_debug;
+bool acpiphp_debug;
/* local variables */
static int num_slots;
@@ -62,7 +61,7 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");
MODULE_PARM_DESC(debug, "Debugging mode enabled or not");
-module_param(debug, bool, 0644);
+module_param_named(debug, acpiphp_debug, bool, 0644);
/* export the attention callback registration methods */
EXPORT_SYMBOL_GPL(acpiphp_register_attention);
@@ -379,8 +378,6 @@ static int __init acpiphp_init(void)
if (acpi_pci_disabled)
return 0;
- acpiphp_debug = debug;
-
/* read all the ACPI info from the system */
return init_acpi();
}
--
1.7.7
next prev parent reply other threads:[~2012-06-23 7:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 7:42 [PATCH 0/5] PCI: hotplug related misc patches Yinghai Lu
2012-06-23 7:42 ` [PATCH 1/5] PCI, acpiphp: remove not used res_lock Yinghai Lu
2012-06-23 7:42 ` [PATCH 2/5] pciehp: Don't enable presence notification while surprise removal is not supported Yinghai Lu
2012-06-26 1:26 ` Kaneshige, Kenji
2012-06-26 18:03 ` Yinghai Lu
2012-07-10 22:56 ` Bjorn Helgaas
2012-07-10 23:12 ` Yinghai Lu
2012-07-10 23:28 ` Bjorn Helgaas
2012-07-10 23:40 ` Yinghai Lu
2012-07-11 16:21 ` Bjorn Helgaas
2012-07-11 17:58 ` Yinghai Lu
2012-07-11 18:15 ` Bjorn Helgaas
2012-07-11 18:49 ` Yinghai Lu
2012-07-11 19:56 ` Bjorn Helgaas
2012-07-11 20:28 ` Yinghai Lu
2012-07-11 20:48 ` Bjorn Helgaas
2012-07-11 20:56 ` Yinghai Lu
2012-07-11 22:24 ` Bjorn Helgaas
2012-07-12 0:05 ` Yinghai Lu
2012-07-12 20:20 ` Bjorn Helgaas
2012-07-13 0:19 ` Yinghai Lu
2012-07-13 15:30 ` Bjorn Helgaas
2012-07-13 18:07 ` Yinghai Lu
2012-06-23 7:42 ` Yinghai Lu [this message]
2012-06-23 7:42 ` [PATCH 4/5] PCI, acpiphp: add is_hotplug_bridge detection Yinghai Lu
2012-07-11 15:50 ` Bjorn Helgaas
2012-07-11 17:14 ` Jason Baron
2012-07-11 19:42 ` Bjorn Helgaas
2012-07-16 16:05 ` Bjorn Helgaas
2012-07-17 14:14 ` Jason Baron
2012-08-15 19:36 ` Bjorn Helgaas
2012-08-20 14:35 ` Jason Baron
2012-08-22 23:19 ` Bjorn Helgaas
2012-09-04 20:55 ` Jason Baron
2012-06-23 7:42 ` [PATCH 5/5] PCI: add root bus children dev's res to fail list Yinghai Lu
2012-07-10 19:30 ` [PATCH 0/5] PCI: hotplug related misc patches Yinghai Lu
2012-07-11 18:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340437325-29282-4-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).