From: Lance Ortiz <lance.ortiz@hp.com>
To: bhelgaas@google.com, ying.huang@intel.com,
jbarnes@virtuousgeek.org, rusty@rustcorp.com.au,
mchehab@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lance.ortiz@hp.com
Subject: [PATCH] aerdrv: Enable AER completion notice
Date: Thu, 19 Jul 2012 13:19:12 -0600 [thread overview]
Message-ID: <1342725552-14407-1-git-send-email-lance.ortiz@hp.com> (raw)
When an AER event occurs not all of the print notifications are at the
same log level. This can cause an incomplete AER log from the users
point of view when monitoring the console output.
The completion message in do_recovery() is currently set to KERN_DEBUG
(log level 7) while the starting message in aer_port_info() uses
KERN_INFO(log level 6). The completion message should be set to
KERN_INFO so it is consistent with the starting message in the log.
The message has also been re-worded to make it more clear. This patch
will enable the AER log on the console output to be book-ended by a
clear and consistent starting and completion message.
Signed-off-by: Lance Ortiz <lance.ortiz@hp.com>
---
drivers/pci/pcie/aer/aerdrv_core.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
index 0ca0535..164bab5 100644
--- a/drivers/pci/pcie/aer/aerdrv_core.c
+++ b/drivers/pci/pcie/aer/aerdrv_core.c
@@ -540,14 +540,14 @@ static void do_recovery(struct pci_dev *dev, int severity)
"resume",
report_resume);
- dev_printk(KERN_DEBUG, &dev->dev,
- "AER driver successfully recovered\n");
+ dev_printk(KERN_INFO, &dev->dev,
+ "AER: Device recovery successful\n");
return;
failed:
/* TODO: Should kernel panic here? */
- dev_printk(KERN_DEBUG, &dev->dev,
- "AER driver didn't recover\n");
+ dev_printk(KERN_INFO, &dev->dev,
+ "AER: Device recovery failed\n");
}
/**
--
1.7.7.6
next reply other threads:[~2012-07-19 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 19:19 Lance Ortiz [this message]
2012-07-30 17:37 ` [PATCH] aerdrv: Enable AER completion notice Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342725552-14407-1-git-send-email-lance.ortiz@hp.com \
--to=lance.ortiz@hp.com \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).