From: Huang Ying <ying.huang@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Huang Ying <ying.huang@intel.com>
Subject: [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices
Date: Mon, 17 Sep 2012 16:54:36 +0800 [thread overview]
Message-ID: <1347872076-5260-4-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1347872076-5260-1-git-send-email-ying.huang@intel.com>
PME poll is not necessary for PCIe devices, because PCIe devices use
in-band PME message and IRQ on PCIe port to report PME.
PME poll is useful for PCI devices. Because for PCI devices, PME is
reported via a side-band PME# line and some platform logic, and the
platform logic is often missing on many systems.
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
drivers/pci/pcie/pme.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -313,6 +313,7 @@ static int pcie_pme_set_native(struct pc
device_set_run_wake(&dev->dev, true);
dev->pme_interrupt = true;
+ dev->pme_poll = false;
return 0;
}
next prev parent reply other threads:[~2012-09-17 8:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 8:54 [RFC 0/3] PCI/PM: RTD3 fixes/changes for 3.7 Huang Ying
2012-09-17 8:54 ` [RFC 1/3] PCI/PM: Fix kexec for D3cold and bridge suspending Huang Ying
2012-09-17 20:54 ` Bjorn Helgaas
2012-09-20 7:38 ` Eric W. Biederman
2012-09-20 8:19 ` Huang Ying
2012-09-20 8:27 ` Eric W. Biederman
2012-09-20 19:20 ` Rafael J. Wysocki
2012-09-21 0:28 ` Huang Ying
2012-09-21 19:30 ` Rafael J. Wysocki
2012-09-17 8:54 ` [RFC 2/3] PCI/PM: Make PCI devices notified when its power resource turned on Huang Ying
2012-09-20 19:33 ` Rafael J. Wysocki
2012-09-17 8:54 ` Huang Ying [this message]
2012-09-20 19:31 ` [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices Rafael J. Wysocki
2012-09-20 19:39 ` Matthew Garrett
2012-09-21 1:50 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347872076-5260-4-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).