linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-pm@vger.kernel.org, Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices
Date: Fri, 21 Sep 2012 09:50:50 +0800	[thread overview]
Message-ID: <1348192250.8212.233.camel@yhuang-dev> (raw)
In-Reply-To: <201209202131.13483.rjw@sisk.pl>

On Thu, 2012-09-20 at 21:31 +0200, Rafael J. Wysocki wrote:
> On Monday, September 17, 2012, Huang Ying wrote:
> > PME poll is not necessary for PCIe devices, because PCIe devices use
> > in-band PME message and IRQ on PCIe port to report PME.
> 
> Alas, not all of them as it turns out and even if they do, it doesn't
> work for some of them. That's why we've added the PCIe devices polling
> (quite recently, for that matter).
> 
> If you'd spent some time on some proper research regarding that (like browsing
> the changelogs of git commits modifying the relevant part of drivers/pci/pci.c),
> you'd have known that already.
> 
> And that actually is quite important, because I don't have to remember every
> single PM-related change we're making in the PCI layer.  I _incidentally_ do
> remember this one, but that may not happen next time.  Please do the research
> _before_ proposing changes of this kind.

Sorry.  I should have done more research before sending the patch out.
Will do more research next time.

Best Regards,
Huang Ying



      parent reply	other threads:[~2012-09-21  1:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17  8:54 [RFC 0/3] PCI/PM: RTD3 fixes/changes for 3.7 Huang Ying
2012-09-17  8:54 ` [RFC 1/3] PCI/PM: Fix kexec for D3cold and bridge suspending Huang Ying
2012-09-17 20:54   ` Bjorn Helgaas
2012-09-20  7:38     ` Eric W. Biederman
2012-09-20  8:19       ` Huang Ying
2012-09-20  8:27         ` Eric W. Biederman
2012-09-20 19:20     ` Rafael J. Wysocki
2012-09-21  0:28       ` Huang Ying
2012-09-21 19:30         ` Rafael J. Wysocki
2012-09-17  8:54 ` [RFC 2/3] PCI/PM: Make PCI devices notified when its power resource turned on Huang Ying
2012-09-20 19:33   ` Rafael J. Wysocki
2012-09-17  8:54 ` [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices Huang Ying
2012-09-20 19:31   ` Rafael J. Wysocki
2012-09-20 19:39     ` Matthew Garrett
2012-09-21  1:50     ` Huang Ying [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348192250.8212.233.camel@yhuang-dev \
    --to=ying.huang@intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).