linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>, Len Brown <lenb@kernel.org>
Cc: linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
	x86@kernel.org
Subject: [PATCH 04/29] PCI, x86: Separate out rom resource claim
Date: Tue, 25 Sep 2012 01:26:05 -0700	[thread overview]
Message-ID: <1348561590-28067-5-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1348561590-28067-1-git-send-email-yinghai@kernel.org>

So could use it with hot-added root bus later.

-v2: remove extra functions.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: x86@kernel.org
---
 arch/x86/pci/i386.c |   52 ++++++++++++++++++++++++++++++++++----------------
 1 files changed, 35 insertions(+), 17 deletions(-)

diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
index 84696ed..42dd755 100644
--- a/arch/x86/pci/i386.c
+++ b/arch/x86/pci/i386.c
@@ -298,27 +298,45 @@ static void __init pcibios_allocate_resources(struct pci_bus *bus, int pass)
 	}
 }
 
-static int __init pcibios_assign_resources(void)
+static void __init pcibios_allocate_dev_rom_resource(struct pci_dev *dev)
 {
-	struct pci_dev *dev = NULL;
 	struct resource *r;
 
-	if (!(pci_probe & PCI_ASSIGN_ROMS)) {
-		/*
-		 * Try to use BIOS settings for ROMs, otherwise let
-		 * pci_assign_unassigned_resources() allocate the new
-		 * addresses.
-		 */
-		for_each_pci_dev(dev) {
-			r = &dev->resource[PCI_ROM_RESOURCE];
-			if (!r->flags || !r->start)
-				continue;
-			if (pci_claim_resource(dev, PCI_ROM_RESOURCE) < 0) {
-				r->end -= r->start;
-				r->start = 0;
-			}
-		}
+	/*
+	 * Try to use BIOS settings for ROMs, otherwise let
+	 * pci_assign_unassigned_resources() allocate the new
+	 * addresses.
+	 */
+	r = &dev->resource[PCI_ROM_RESOURCE];
+	if (!r->flags || !r->start)
+		return;
+
+	if (pci_claim_resource(dev, PCI_ROM_RESOURCE) < 0) {
+		r->end -= r->start;
+		r->start = 0;
 	}
+}
+static void __init pcibios_allocate_rom_resources(struct pci_bus *bus)
+{
+	struct pci_dev *dev;
+	struct pci_bus *child;
+
+	list_for_each_entry(dev, &bus->devices, bus_list) {
+		pcibios_allocate_dev_rom_resource(dev);
+
+		child = dev->subordinate;
+		if (child)
+			pcibios_allocate_rom_resources(child);
+	}
+}
+
+static int __init pcibios_assign_resources(void)
+{
+	struct pci_bus *bus;
+
+	if (!(pci_probe & PCI_ASSIGN_ROMS))
+		list_for_each_entry(bus, &pci_root_buses, node)
+			pcibios_allocate_rom_resources(bus);
 
 	pci_assign_unassigned_resources();
 	pcibios_fw_addr_list_del();
-- 
1.7.7


  parent reply	other threads:[~2012-09-25  8:26 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25  8:26 [PATCH 00/29] PCI: use pci host bridge to loop pci root bus Yinghai Lu
2012-09-25  8:26 ` [PATCH 01/29] PCI, x86: Separate out pcibios_allocate_bridge_resources() Yinghai Lu
2012-09-25  8:26 ` [PATCH 02/29] PCI. x86: Separate out pcibios_allocate_dev_resources() Yinghai Lu
2012-09-25  8:26 ` [PATCH 03/29] PCI, x86: Let pcibios_allocate_bus_resources() take bus instead Yinghai Lu
2012-09-25  8:26 ` Yinghai Lu [this message]
2012-09-25  8:26 ` [PATCH 05/29] PCI: rename pci_release_bus_bridge_dev to pci_release_host_bridge_dev Yinghai Lu
2012-09-25  8:26 ` [PATCH 06/29] PCI: Add dummy bus_type for pci_host_bridge Yinghai Lu
2012-09-25  8:26 ` [PATCH 07/29] PCI, ACPI: add acpi_bus_type for host bridge Yinghai Lu
2012-09-25  8:26 ` [PATCH 08/29] PCI, ACPI: Remove acpi_find_bridge_device for acpi_bus_type Yinghai Lu
2012-09-25  8:26 ` [PATCH 09/29] PCI, libata: remove find_bridge in acpi_bus_type Yinghai Lu
2012-09-25 16:23   ` Jeff Garzik
2012-09-25  8:26 ` [PATCH 10/29] PCI, USB: " Yinghai Lu
2012-09-25  8:35   ` Lan Tianyu
2012-09-25 16:57     ` Yinghai Lu
2012-09-27 20:21       ` Yinghai Lu
2012-09-28  5:48         ` Lan Tianyu
2012-09-25  8:26 ` [PATCH 11/29] PCI, ACPI: " Yinghai Lu
2012-09-25  8:26 ` [PATCH 12/29] PCI: Add for_each_pci_host_bridge() and pci_get_next_host_bridge Yinghai Lu
2012-09-25 14:51   ` Jiang Liu
2012-09-25 14:59     ` Yinghai Lu
2012-09-25 15:04   ` Jiang Liu
2012-09-25 15:56   ` [PATCH] " Jiang Liu
2012-09-25 16:25     ` Yinghai Lu
2012-09-25  8:26 ` [PATCH 13/29] PCI, hotplug: kill pci_find_next_bus n sgi_hotplug Yinghai Lu
2012-09-25  8:26 ` [PATCH 14/29] PCI: kill pci_find_next_bus in pci_sysfs Yinghai Lu
2012-09-25  8:26 ` [PATCH 15/29] PCI, edac: kill pci_find_next_bus in edac Yinghai Lu
2012-09-25  9:20   ` Mauro Carvalho Chehab
2012-09-25  8:26 ` [PATCH 16/29] PCI, x86: kill pci_find_next_bus in pcibios_scan_root Yinghai Lu
2012-09-25  8:26 ` [PATCH 17/29] PCI, x86: kill pci_root_buses in resources reservations Yinghai Lu
2012-09-25  8:26 ` [PATCH 18/29] PCI, drm: kill pci_root_buses in alpha hose setting Yinghai Lu
2012-09-25  8:26 ` [PATCH 19/29] PCI: kill pci_root_buses in setup-bus Yinghai Lu
2012-09-25  8:26 ` [PATCH 20/29] PCI, sparc: kill pci_find_next_bus Yinghai Lu
2012-09-25  8:40   ` Jurij Smakov
2012-09-25 16:33     ` Yinghai Lu
2012-09-25 17:05   ` David Miller
2012-09-25  8:26 ` [PATCH 21/29] PCI, ia64: " Yinghai Lu
2012-09-25  8:26 ` [PATCH 22/29] PCI, alpha: kill pci_root_buses Yinghai Lu
2012-09-25  8:26 ` [PATCH 23/29] PCI, arm: " Yinghai Lu
2012-09-25  8:26 ` [PATCH 24/29] PCI, frv: kill pci_root_buses in resources reservations Yinghai Lu
2012-09-25  8:26 ` [PATCH 25/29] PCI, microblaze: " Yinghai Lu
2012-09-25  8:26 ` [PATCH 26/29] PCI, mn10300: " Yinghai Lu
2012-09-25  8:26 ` [PATCH 27/29] PCI, powerpc: " Yinghai Lu
2012-09-25  8:26 ` [PATCH 28/29] PCI: kill pci_find_next_bus Yinghai Lu
2012-09-25  8:26 ` [PATCH 29/29] PCI: kill pci_root_buses Yinghai Lu
2012-09-25 16:23 ` [PATCH 00/29] PCI: use pci host bridge to loop pci root bus Bjorn Helgaas
2012-09-25 16:29   ` Yinghai Lu
2012-09-25 17:37     ` Bjorn Helgaas
2012-09-25 18:06       ` Yinghai Lu
2012-09-25 18:19         ` Bjorn Helgaas
2012-09-25 19:17           ` Yinghai Lu
2012-09-25 19:45             ` Bjorn Helgaas
2012-09-25 19:53               ` Yinghai Lu
2012-09-25 20:06                 ` Bjorn Helgaas
2012-09-25 22:44                   ` Yinghai Lu
2012-09-25 19:38 ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348561590-28067-5-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=lenb@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).