linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Huang Ying <ying.huang@intel.com>
Subject: [BUGFIX 2/2] PCI/PM: Resume device before shutdown
Date: Wed, 24 Oct 2012 14:54:14 +0800	[thread overview]
Message-ID: <1351061654-8339-2-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1351061654-8339-1-git-send-email-ying.huang@intel.com>

Some actions during shutdown need device to be in D0 state, such as
MSI shutdown etc, so resume device before shutdown.

Signed-off-by: Huang Ying <ying.huang@intel.com>
---
 drivers/pci/pci-driver.c |   12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -398,6 +398,8 @@ static void pci_device_shutdown(struct d
 	struct pci_dev *pci_dev = to_pci_dev(dev);
 	struct pci_driver *drv = pci_dev->driver;
 
+	pm_runtime_resume(dev);
+
 	if (drv && drv->shutdown)
 		drv->shutdown(pci_dev);
 	pci_msi_shutdown(pci_dev);
@@ -408,16 +410,6 @@ static void pci_device_shutdown(struct d
 	 * continue to do DMA
 	 */
 	pci_disable_device(pci_dev);
-
-	/*
-	 * Devices may be enabled to wake up by runtime PM, but they need not
-	 * be supposed to wake up the system from its "power off" state (e.g.
-	 * ACPI S5).  Therefore disable wakeup for all devices that aren't
-	 * supposed to wake up the system at this point.  The state argument
-	 * will be ignored by pci_enable_wake().
-	 */
-	if (!device_may_wakeup(dev))
-		pci_enable_wake(pci_dev, PCI_UNKNOWN, false);
 }
 
 #ifdef CONFIG_PM

  reply	other threads:[~2012-10-24  6:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24  6:54 [BUGFIX 1/2] PCI/PM: Fix deadlock when unbind device if its parent in D3cold Huang Ying
2012-10-24  6:54 ` Huang Ying [this message]
2012-10-24 21:01   ` [BUGFIX 2/2] PCI/PM: Resume device before shutdown Rafael J. Wysocki
2012-11-02 16:52   ` Bjorn Helgaas
2012-11-02 20:26     ` Rafael J. Wysocki
2012-11-03  5:05     ` Huang Ying
2012-11-03 17:21       ` Bjorn Helgaas
2012-11-04  3:44         ` Huang Ying
2012-10-24 21:01 ` [BUGFIX 1/2] PCI/PM: Fix deadlock when unbind device if its parent in D3cold Rafael J. Wysocki
2012-11-02 16:50 ` Bjorn Helgaas
2012-11-02 20:27   ` Rafael J. Wysocki
2012-11-03  5:06   ` Huang Ying
2012-11-03 17:22     ` Bjorn Helgaas
2012-11-04  3:38       ` Huang Ying
2012-11-05 22:11         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351061654-8339-2-git-send-email-ying.huang@intel.com \
    --to=ying.huang@intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).