From: Alex Williamson <alex.williamson@redhat.com>
To: Alex Lyakas <alex@zadarastorage.com>
Cc: kvm@vger.kernel.org, linux-pci@vger.kernel.org,
Yair Hershko <yair@zadarastorage.com>,
Shyam Kaushik <shyam@zadarastorage.com>
Subject: Re: pci_enable_msix() fails with ENOMEM/EINVAL
Date: Thu, 29 Nov 2012 08:56:10 -0700 [thread overview]
Message-ID: <1354204570.14547.14.camel@ul30vt.home> (raw)
In-Reply-To: <A5D6C5E3D7774E62AA482C886483DA6D@alyakaslap>
On Thu, 2012-11-29 at 10:42 +0200, Alex Lyakas wrote:
> Hi Alex,
> did I understand correctly that "vector" value with which the call to
> request_threaded_irq() is made is *not* supposed to be zero? Because in my
> case, it is always zero, and still the failure I observe is not happening
> always. Usually, 3 unique (non-zero) IRQ numbers are assigned to each
> attached PCI device of each KVM VM.
> I will try to repro this like you suggested and let you know.
pci_enable_msix should be setting vectors for all the host_msix_entries.
That non-zero vector is the first parameter to request_threaded_irq. If
I put a printk in the loop installing the interrupt handler, I get:
assigned_device_enable_host_msix entry 0, vector 44
assigned_device_enable_host_msix entry 0, vector 44
assigned_device_enable_host_msix entry 1, vector 45
assigned_device_enable_host_msix entry 0, vector 44
assigned_device_enable_host_msix entry 1, vector 45
assigned_device_enable_host_msix entry 2, vector 103
So we enable MSI-X with only one vector enabled, then a second vector
gets enabled and we disable and re-enable with two, and so on with
three. This is for an assigned e1000e device. Thanks,
Alex
next prev parent reply other threads:[~2012-11-29 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <190FFE9600054603A543CCDA4408AC89@alyakaslap>
[not found] ` <CAOcd+r28ot-060WQhUPkuM1Bt7t-_jOggAZKNSJxurNYVs2b-w@mail.gmail.com>
[not found] ` <1353536723.1809.4.camel@bling.home>
[not found] ` <F764A8A9BBE247FEA862ED33F77A04A1@alyakaslap>
[not found] ` <1353960253.1809.128.camel@bling.home>
2012-11-29 8:42 ` pci_enable_msix() fails with ENOMEM/EINVAL Alex Lyakas
2012-11-29 15:56 ` Alex Williamson [this message]
2012-12-08 12:14 ` Alex Lyakas
2012-12-10 20:45 ` Alex Williamson
2012-12-12 13:42 ` Alex Lyakas
2012-12-12 20:10 ` Alex Williamson
2012-12-18 14:46 ` Alex Lyakas
2012-12-19 23:39 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354204570.14547.14.camel@ul30vt.home \
--to=alex.williamson@redhat.com \
--cc=alex@zadarastorage.com \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=shyam@zadarastorage.com \
--cc=yair@zadarastorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).