From: Joe Perches <joe@perches.com>
To: Lance Ortiz <lance.ortiz@hp.com>
Cc: bhelgaas@google.com, lance_ortiz@hotmail.com,
jiang.liu@huawei.com, tony.luck@intel.com, bp@alien8.de,
rostedt@goodmis.org, mchehab@redhat.com,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] aerdrv: Enhanced AER logging
Date: Thu, 29 Nov 2012 14:11:45 -0800 [thread overview]
Message-ID: <1354227105.1700.15.camel@joe-AO722> (raw)
In-Reply-To: <20121129215450.5483.26562.stgit@grignak.americas.hpqcorp.net>
On Thu, 2012-11-29 at 14:54 -0700, Lance Ortiz wrote:
> This patch will provide a more reliable and easy way for user-space
> applications to have access to AER logs rather than reading them from the
> message buffer. It also provides a way to notify user-space when an AER
> event occurs.
[]
> diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c
> index e6defd8..ef1e1c0 100644
> --- a/drivers/acpi/apei/cper.c
> +++ b/drivers/acpi/apei/cper.c
> @@ -281,9 +281,16 @@ static void cper_print_pcie(const char *pfx, const struct cper_sec_pcie *pcie,
> "%s""bridge: secondary_status: 0x%04x, control: 0x%04x\n",
> pfx, pcie->bridge.secondary_status, pcie->bridge.control);
> #ifdef CONFIG_ACPI_APEI_PCIEAER
> - if (pcie->validation_bits & CPER_PCIE_VALID_AER_INFO) {
> + dev = pci_get_domain_bus_and_slot(pcie->device_id.segment,
> + pcie->device_id.bus, pcie->device_id.function);
> + if (!dev)
> + pr_info(KERN_INFO, "PCI AER Cannot get PCI device %04x:%02x:%02x.%d\n",
> + domain, bus, slot, func);
You've not tried this with CONFIG_ACPI_APEI_PCIEAER enabled.
pr_info("PCI AER Cannot get PCI device %04x:%02x:%02x.%d\n",
domain, bus, slot, func);
next prev parent reply other threads:[~2012-11-29 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 21:54 [PATCH 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-11-29 21:54 ` [PATCH 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-11-29 22:11 ` Joe Perches [this message]
2012-11-29 22:21 ` Ortiz, Lance E
2012-11-30 1:53 ` Steven Rostedt
2012-11-29 21:54 ` [PATCH 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-11-30 1:51 ` [PATCH 1/3] aerdrv: Trace Event for AER Steven Rostedt
2012-11-30 10:53 ` Borislav Petkov
2012-11-30 11:39 ` Steven Rostedt
2012-11-30 13:42 ` Borislav Petkov
2012-11-30 13:53 ` Steven Rostedt
2012-11-30 17:36 ` Borislav Petkov
2012-11-30 18:18 ` Ortiz, Lance E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354227105.1700.15.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jiang.liu@huawei.com \
--cc=lance.ortiz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).