From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Lance Ortiz <lance.ortiz@hp.com>,
bhelgaas@google.com, lance_ortiz@hotmail.com,
jiang.liu@huawei.com, tony.luck@intel.com, mchehab@redhat.com,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] aerdrv: Trace Event for AER
Date: Fri, 30 Nov 2012 08:53:51 -0500 [thread overview]
Message-ID: <1354283631.6276.143.camel@gandalf.local.home> (raw)
In-Reply-To: <20121130134232.GD6869@liondog.tnic>
On Fri, 2012-11-30 at 14:42 +0100, Borislav Petkov wrote:
> So, it sounds to me like we should we move all RAS-specific tracepoints
> to <trace/events/ras.h> and then in each usage site do:
Note, the CREATE_TRACE_POINTS must only be done in one location. Not
every place. It creates the code that does the work to make the
tracepoints show up in /debug/tracing/events/* as well as the callback
code and other such things. If you define it in more than one .c file,
then you will have linker issues due to the functions being created more
than once.
>
> #define CREATE_TRACE_POINTS
> #include <trace/events/ras.h>
>
> Correct?
That's the default way to do things.
>
> FWIW, it looks neat and clean to me that way.
Yep, that's why it's default ;-)
-- Steve
next prev parent reply other threads:[~2012-11-30 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 21:54 [PATCH 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-11-29 21:54 ` [PATCH 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-11-29 22:11 ` Joe Perches
2012-11-29 22:21 ` Ortiz, Lance E
2012-11-30 1:53 ` Steven Rostedt
2012-11-29 21:54 ` [PATCH 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-11-30 1:51 ` [PATCH 1/3] aerdrv: Trace Event for AER Steven Rostedt
2012-11-30 10:53 ` Borislav Petkov
2012-11-30 11:39 ` Steven Rostedt
2012-11-30 13:42 ` Borislav Petkov
2012-11-30 13:53 ` Steven Rostedt [this message]
2012-11-30 17:36 ` Borislav Petkov
2012-11-30 18:18 ` Ortiz, Lance E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354283631.6276.143.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jiang.liu@huawei.com \
--cc=lance.ortiz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).