From: Hannes Reinecke <hare@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Hannes Reinecke <hare@suse.de>, Frederik Himpe <fhimpe@vub.ac.be>,
Oliver Neukum <oneukum@suse.de>,
David Haerdeman <david@hardeman.nu>,
linux-usb@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH] pci: do not try to assign irq 255
Date: Mon, 18 Feb 2013 11:09:53 +0100 [thread overview]
Message-ID: <1361182193-31894-1-git-send-email-hare@suse.de> (raw)
The PCI config space reseves a byte for the interrupt line,
so irq 255 actually refers to 'not set'.
However, the 'irq' field for struct pci_dev is an integer,
so the original meaning is lost, causing the system to
assign an interrupt '255', which fails.
So we should _not_ assign an interrupt value here, and
allow upper layers to fixup things.
This patch make PCI devices with MSI interrupts only
(like the xhci device on certain HP laptops) work properly.
Cc: Frederik Himpe <fhimpe@vub.ac.be>
Cc: Oliver Neukum <oneukum@suse.de>
Cc: David Haerdeman <david@hardeman.nu>
Cc: linux-usb@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Signed-off-by: Hannes Reinecke <hare@suse.de>
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 6186f03..a2db887f 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -923,7 +923,8 @@ static void pci_read_irq(struct pci_dev *dev)
dev->pin = irq;
if (irq)
pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
- dev->irq = irq;
+ if (irq < 255)
+ dev->irq = irq;
}
void set_pcie_port_type(struct pci_dev *pdev)
next reply other threads:[~2013-02-18 10:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 10:09 Hannes Reinecke [this message]
2013-02-19 1:13 ` [PATCH] pci: do not try to assign irq 255 David Härdeman
2013-02-19 19:40 ` Yinghai Lu
2013-02-20 7:58 ` Hannes Reinecke
2013-02-20 16:57 ` Yinghai Lu
2013-02-21 6:53 ` Hannes Reinecke
2013-02-26 13:29 ` David Härdeman
2013-02-26 13:50 ` Hannes Reinecke
2013-02-27 21:13 ` Bjorn Helgaas
2013-02-28 16:13 ` Hannes Reinecke
2013-03-01 7:41 ` Hannes Reinecke
2013-03-05 22:41 ` Sarah Sharp
2013-03-26 21:54 ` Bjorn Helgaas
2013-03-26 23:34 ` Yinghai Lu
2013-09-10 21:53 ` Bjorn Helgaas
2013-02-19 19:47 ` Bjorn Helgaas
2013-02-19 22:36 ` Frederik Himpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361182193-31894-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=david@hardeman.nu \
--cc=fhimpe@vub.ac.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).