From: Shuah Khan <shuah@fc.hp.com>
To: Bjorn Helgaas <bhelgaas@google.com>, joro@8bytes.org
Cc: dhowells@redhat.com, paulmck@linux.vnet.ibm.com,
linasvepstas@gmail.com, davej@redhat.com, tglx@linutronix.de,
mtk.manpages@gmail.com, iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, shemminger@vyatta.com,
jiang.liu@huawei.com, wangyijing@huawei.com, shuahkhan@gmail.com
Subject: Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id
Date: Wed, 27 Feb 2013 14:48:20 -0700 [thread overview]
Message-ID: <1362001700.2808.9.camel@lorien2> (raw)
In-Reply-To: <1361829202.2958.3.camel@lorien2>
On Mon, 2013-02-25 at 14:53 -0700, Shuah Khan wrote:
> On Mon, 2013-02-25 at 14:23 -0700, Bjorn Helgaas wrote:
> > On Mon, Feb 25, 2013 at 9:37 AM, Shuah Khan <shuah.khan@hp.com> wrote:
> > > On Wed, 2013-02-20 at 18:19 -0700, Bjorn Helgaas wrote:
> > >> On Mon, Feb 11, 2013 at 4:00 PM, Shuah Khan <shuah.khan@hp.com> wrote:
> >
> > It's not nice and consistent, but it does follow the simple rule of
> > "don't expose things to user-space unnecessarily." We might want to
> > add a comment to keep somebody from cleaning it up later.
>
> ok. Will resend patches adding the new defines to linux/pci.h and
> renaming PCI_BUS() to PCI_BUS_NR() or PCI_BUS_NUM() like you suggested.
>
> Thanks,
> -- Shuah
>
Bjorn/Joerg,
I added PCI_BUS_NUM() amd PCI_DEVID() to linux/pci.h. Please note that
changing PCI_BUS() to PCI_BUS_NUM() required additional changes to AMD
IOMMU source files and aer driver. Essentially in addition to removing
local PCI_BUS() define, PCI_BUS() usages are changed to PCI_BUS_NUM(). I
am resending the patches.
Thanks,
-- Shuah
next prev parent reply other threads:[~2013-02-27 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 23:00 [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id Shuah Khan
2013-02-21 1:19 ` Bjorn Helgaas
2013-02-25 16:37 ` Shuah Khan
2013-02-25 21:23 ` Bjorn Helgaas
2013-02-25 21:53 ` Shuah Khan
2013-02-27 21:48 ` Shuah Khan [this message]
2013-02-25 21:28 ` Bjorn Helgaas
2013-02-26 0:45 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362001700.2808.9.camel@lorien2 \
--to=shuah@fc.hp.com \
--cc=bhelgaas@google.com \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@huawei.com \
--cc=joro@8bytes.org \
--cc=linasvepstas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
--cc=shuahkhan@gmail.com \
--cc=tglx@linutronix.de \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).