From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1362001700.2808.9.camel@lorien2> Subject: Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id From: Shuah Khan Reply-To: shuah@fc.hp.com To: Bjorn Helgaas , joro@8bytes.org Cc: dhowells@redhat.com, paulmck@linux.vnet.ibm.com, linasvepstas@gmail.com, davej@redhat.com, tglx@linutronix.de, mtk.manpages@gmail.com, iommu@lists.linux-foundation.org, LKML , linux-pci@vger.kernel.org, shemminger@vyatta.com, jiang.liu@huawei.com, wangyijing@huawei.com, shuahkhan@gmail.com Date: Wed, 27 Feb 2013 14:48:20 -0700 In-Reply-To: <1361829202.2958.3.camel@lorien2> References: <1360623637.2950.63.camel@lorien2> <1361810245.2975.14.camel@lorien2> <1361829202.2958.3.camel@lorien2> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, 2013-02-25 at 14:53 -0700, Shuah Khan wrote: > On Mon, 2013-02-25 at 14:23 -0700, Bjorn Helgaas wrote: > > On Mon, Feb 25, 2013 at 9:37 AM, Shuah Khan wrote: > > > On Wed, 2013-02-20 at 18:19 -0700, Bjorn Helgaas wrote: > > >> On Mon, Feb 11, 2013 at 4:00 PM, Shuah Khan wrote: > > > > It's not nice and consistent, but it does follow the simple rule of > > "don't expose things to user-space unnecessarily." We might want to > > add a comment to keep somebody from cleaning it up later. > > ok. Will resend patches adding the new defines to linux/pci.h and > renaming PCI_BUS() to PCI_BUS_NR() or PCI_BUS_NUM() like you suggested. > > Thanks, > -- Shuah > Bjorn/Joerg, I added PCI_BUS_NUM() amd PCI_DEVID() to linux/pci.h. Please note that changing PCI_BUS() to PCI_BUS_NUM() required additional changes to AMD IOMMU source files and aer driver. Essentially in addition to removing local PCI_BUS() define, PCI_BUS() usages are changed to PCI_BUS_NUM(). I am resending the patches. Thanks, -- Shuah