Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: "Qiang Yu" <qiang.yu@oss.qualcomm.com>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Cc: shawn.lin@rock-chips.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: dwc: Fix grammar and formatting in dw_pcie_remove_ext_capability()
Date: Thu, 22 Jan 2026 16:10:09 +0800	[thread overview]
Message-ID: <1363546a-328b-4242-b1e9-9daa009d2b3c@rock-chips.com> (raw)
In-Reply-To: <20260121-remove_cap_clean_up-v1-1-e78115e5d467@oss.qualcomm.com>


在 2026/01/22 星期四 15:45, Qiang Yu 写道:
> Fix a grammatical error in the comment by changing "it's" to "its". Also
> add a blank line after the variable declaration for better code
> formatting.
> 

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
> ---
>   drivers/pci/controller/dwc/pcie-designware.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 2fa9f6ee149ed76ee84e8129a47f4bde2fa4d513..18331d9e85be30462277532afa71b5850438f32e 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -268,9 +268,10 @@ void dw_pcie_remove_ext_capability(struct dw_pcie *pci, u8 cap)
>   		return;
>   
>   	header = dw_pcie_readl_dbi(pci, cap_pos);
> +
>   	/*
>   	 * If the first cap at offset PCI_CFG_SPACE_SIZE is removed,
> -	 * only set it's capid to zero as it cannot be skipped.
> +	 * only set its capid to zero as it cannot be skipped.
>   	 */
>   	if (cap_pos == PCI_CFG_SPACE_SIZE) {
>   		dw_pcie_dbi_ro_wr_en(pci);
> 


  reply	other threads:[~2026-01-22  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  7:45 [PATCH 0/2] PCI: dwc: Code clean up and formatting improvements Qiang Yu
2026-01-22  7:45 ` [PATCH 1/2] PCI: dwc: Fix grammar and formatting in dw_pcie_remove_ext_capability() Qiang Yu
2026-01-22  8:10   ` Shawn Lin [this message]
2026-01-22  7:45 ` [PATCH 2/2] PCI: dwc: Rename has_msi_ctrl to uses_imsi_rx for clarity Qiang Yu
2026-01-22  8:15   ` Shawn Lin
2026-01-23  6:10     ` Qiang Yu
2026-01-23  7:34       ` Manivannan Sadhasivam
2026-01-23  7:33 ` [PATCH 0/2] PCI: dwc: Code clean up and formatting improvements Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363546a-328b-4242-b1e9-9daa009d2b3c@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=bhelgaas@google.com \
    --cc=jingoohan1@gmail.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=qiang.yu@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox