From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org ([63.228.1.57]:53023 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932574Ab3DBPKm (ORCPT ); Tue, 2 Apr 2013 11:10:42 -0400 Message-ID: <1364915422.16520.8.camel@pasglop> Subject: Re: [PATCH] powerpc/pci: fix PCI-e devices rescan issue on powerpc platform From: Benjamin Herrenschmidt To: Yuanquan Chen Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, bhelgaas@google.com, Hiroo Matsumoto Date: Tue, 02 Apr 2013 17:10:22 +0200 In-Reply-To: <1364902014-943-1-git-send-email-Yuanquan.Chen@freescale.com> References: <1364902014-943-1-git-send-email-Yuanquan.Chen@freescale.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, 2013-04-02 at 19:26 +0800, Yuanquan Chen wrote: > So we move the DMA & IRQ initialization code from pcibios_setup_devices() and > construct a new function pcibios_enable_device. We call this function in > pcibios_enable_device, which will be called by PCI-e rescan code. At the > meanwhile, we avoid the the impact on cardbus. I also validate this patch with > silicon's PCIe-sata which encounters the IRQ issue. My worry is that this delays the setup of the IRQ and DMA to very late in the process, possibly after the quirks have been run, which can be problematic. We have platform hooks that might try to "fixup" specific IRQ issues on some platforms (especially macs) which I worry might fail if delayed that way (I may be wrong, I don't have a specific case in mind, but I would feel better if we kept setting up these things earlier). Cheers, Ben.