From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Cc: linux-pci@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] PowerNV/PCI: Fix NULL PCI controller
Date: Mon, 22 Apr 2013 18:04:27 +1000 [thread overview]
Message-ID: <1366617867.2723.23.camel@pasglop> (raw)
In-Reply-To: <5174E9C3.6080203@linux.vnet.ibm.com>
On Mon, 2013-04-22 at 15:41 +0800, Mike Qiu wrote:
> Anyway, I think it's better to remove the check code as it is useless,
> as it
> will shows that this "NULL" pci_controller pointer may happen...
Ok. It *might* still be worth adding a BUG_ON then in pci_bus_to_host()
itself ... no big deal either way.
Cheers,
Ben.
next prev parent reply other threads:[~2013-04-22 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 6:13 [PATCH] PowerNV/PCI: Fix NULL PCI controller Mike Qiu
2013-04-22 6:15 ` Mike Qiu
2013-04-22 6:36 ` Benjamin Herrenschmidt
2013-04-22 7:41 ` Mike Qiu
2013-04-22 8:04 ` Benjamin Herrenschmidt [this message]
2013-04-22 9:44 ` Mike Qiu
2013-04-22 17:35 ` Bjorn Helgaas
2013-04-23 1:46 ` Mike Qiu
2013-04-23 1:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366617867.2723.23.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox