From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: bhelgaas@google.com, gregory.v.rose@intel.com,
alexander.h.duyck@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com, linux-pci@vger.kernel.org
Subject: Re: [net-next 08/14] pci: Add SRIOV helper function to determine if VFs are assigned to guest
Date: Wed, 24 Apr 2013 14:40:36 -0700 [thread overview]
Message-ID: <1366839636.2871.7.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20130424.161825.1007847105309092978.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Wed, 2013-04-24 at 16:18 -0400, David Miller wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> Date: Wed, 24 Apr 2013 14:10:38 -0600
>
> > But this is no worse in either respect than the code it replaces, and
> > it's certainly better to have it all in one place, so:
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> >
> > If you have a chance, you could remove the "extern" from the
> > declaration in include/linux/pci.h. There's a mix there right now,
> > and I have a patch in the queue that removes them all.
>
> Jeff please respin your pull request with Bjorn's ACK as well as
> the "extern" removal he's asking for.
>
> Thanks.
Working on it, I will have a updated patch (and series) submitted later
tonight.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-24 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1366451353-24714-1-git-send-email-jeffrey.t.kirsher@intel.com>
[not found] ` <1366451353-24714-9-git-send-email-jeffrey.t.kirsher@intel.com>
2013-04-21 3:31 ` [net-next 08/14] pci: Add SRIOV helper function to determine if VFs are assigned to guest Jeff Kirsher
[not found] ` <20130421051423.GA4052@shangw.(null)>
2013-04-22 16:13 ` Alexander Duyck
2013-04-22 20:09 ` Bjorn Helgaas
2013-04-22 21:50 ` Alexander Duyck
2013-04-23 19:51 ` Greg Rose
2013-04-23 21:16 ` Don Dutile
2013-04-24 20:10 ` Bjorn Helgaas
2013-04-24 20:18 ` David Miller
2013-04-24 21:40 ` Jeff Kirsher [this message]
2013-04-24 21:35 ` Greg Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366839636.2871.7.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).