From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>,
Doug Thompson <dougthompson@xmission.com>
Cc: linux-pci@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH] PCI, EDAC: fix ordering assign resource and bus_add
Date: Tue, 7 May 2013 16:29:31 -0700 [thread overview]
Message-ID: <1367969371-27414-1-git-send-email-yinghai@kernel.org> (raw)
We should assign unassigned resource before pci_bus_add_device.
as late one will enable driver and create sysfs file that will need
pci io resources from assign unassigned code.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/edac/i82875p_edac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/edac/i82875p_edac.c
===================================================================
--- linux-2.6.orig/drivers/edac/i82875p_edac.c
+++ linux-2.6/drivers/edac/i82875p_edac.c
@@ -293,13 +293,14 @@ static int i82875p_setup_overfl_dev(stru
if (dev == NULL)
return 1;
+ pci_bus_assign_resources(dev->bus);
+
err = pci_bus_add_device(dev);
if (err) {
i82875p_printk(KERN_ERR,
"%s(): pci_bus_add_device() Failed\n",
__func__);
}
- pci_bus_assign_resources(dev->bus);
}
*ovrfl_pdev = dev;
next reply other threads:[~2013-05-07 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 23:29 Yinghai Lu [this message]
2014-05-30 17:01 ` [PATCH] PCI, EDAC: fix ordering assign resource and bus_add Bjorn Helgaas
2014-05-30 21:46 ` Borislav Petkov
2014-05-30 22:00 ` Bjorn Helgaas
2014-05-30 22:21 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367969371-27414-1-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).