From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 1/7] PCI: move back pci_proc_attach_devices calling
Date: Mon, 13 May 2013 19:28:20 -0700 [thread overview]
Message-ID: <1368498506-25857-2-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1368498506-25857-1-git-send-email-yinghai@kernel.org>
We stop detach proc when pci_stop_device.
So should attach that during pci_bus_add_device.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/bus.c | 1 +
drivers/pci/probe.c | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/probe.c
===================================================================
--- linux-2.6.orig/drivers/pci/probe.c
+++ linux-2.6/drivers/pci/probe.c
@@ -1348,8 +1348,6 @@ void pci_device_add(struct pci_dev *dev,
dev->match_driver = false;
ret = device_add(&dev->dev);
WARN_ON(ret < 0);
-
- pci_proc_attach_device(dev);
}
struct pci_dev *__ref pci_scan_single_device(struct pci_bus *bus, int devfn)
Index: linux-2.6/drivers/pci/bus.c
===================================================================
--- linux-2.6.orig/drivers/pci/bus.c
+++ linux-2.6/drivers/pci/bus.c
@@ -175,6 +175,7 @@ int pci_bus_add_device(struct pci_dev *d
* are not assigned yet for some devices.
*/
pci_fixup_device(pci_fixup_final, dev);
+ pci_proc_attach_device(dev);
pci_create_sysfs_dev_files(dev);
dev->match_driver = true;
next prev parent reply other threads:[~2013-05-14 2:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 2:28 [PATCH 0/7] PCI: fix pci dev add and remove sequence Yinghai Lu
2013-05-14 2:28 ` Yinghai Lu [this message]
2013-05-14 2:28 ` [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev Yinghai Lu
2013-05-14 3:20 ` Yijing Wang
2013-05-14 3:56 ` Yinghai Lu
2013-05-14 6:02 ` Yijing Wang
2013-05-14 2:28 ` [PATCH 3/7] PCI: Detach driver in pci_stop_device Yinghai Lu
2013-05-14 2:28 ` [PATCH 4/7] PCI: Fix racing for pci device removing via sysfs Yinghai Lu
2013-05-16 7:52 ` Gu Zheng
2013-05-14 2:28 ` [PATCH 5/7] PCI, ACPI: Don't glue ACPI dev with pci VFs Yinghai Lu
2013-05-14 2:28 ` [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's Yinghai Lu
2013-05-14 8:58 ` Yan Burman
2013-05-14 15:43 ` Yinghai Lu
2013-05-16 4:00 ` Or Gerlitz
2013-05-16 4:39 ` Yinghai Lu
2013-05-16 4:56 ` Or Gerlitz
2013-05-16 17:53 ` Tejun Heo
2013-05-16 18:36 ` Yinghai Lu
2013-05-20 12:23 ` Or Gerlitz
2013-05-14 9:46 ` Perla, Sathya
2013-05-14 15:19 ` Yinghai Lu
2013-05-14 16:00 ` Alexander Duyck
2013-05-14 18:44 ` Yinghai Lu
2013-05-14 19:45 ` Alexander Duyck
2013-05-14 19:59 ` Yinghai Lu
2013-05-14 21:39 ` Alexander Duyck
2013-05-21 21:30 ` Don Dutile
2013-05-21 21:31 ` Don Dutile
2013-05-21 21:58 ` Alexander Duyck
2013-05-21 22:09 ` Don Dutile
2013-05-21 22:12 ` Alexander Duyck
2013-05-21 21:49 ` Michael S. Tsirkin
2013-05-21 22:01 ` Alexander Duyck
2013-05-21 22:11 ` Michael S. Tsirkin
2013-05-21 22:30 ` Alexander Duyck
2013-05-22 20:16 ` Or Gerlitz
2013-05-22 21:40 ` Don Dutile
2013-05-23 6:43 ` Or Gerlitz
2013-05-22 23:45 ` Ben Hutchings
2013-05-23 6:32 ` Or Gerlitz
2013-05-16 6:39 ` Michael S. Tsirkin
2013-05-14 2:28 ` [PATCH 7/7] PCI: use pf as dma_dev for vf that does not have func0 sibling Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368498506-25857-2-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).