From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 5/7] PCI, ACPI: Don't glue ACPI dev with pci VFs
Date: Mon, 13 May 2013 19:28:24 -0700 [thread overview]
Message-ID: <1368498506-25857-6-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1368498506-25857-1-git-send-email-yinghai@kernel.org>
When sriov is enabled, VF could just start after PF in pci tree.
like c1:00.0 will be PF, and c1:00.1 and after will be VF.
acpi do have dev with same ADR. that will make them get glued
wrongly.
Skip that if it is virtfn.
Also need to set is_virtfn before pci_device_add(), as
gluing is triggered by device_add().
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/iov.c | 6 +++---
drivers/pci/pci-acpi.c | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/pci/iov.c
===================================================================
--- linux-2.6.orig/drivers/pci/iov.c
+++ linux-2.6/drivers/pci/iov.c
@@ -110,12 +110,12 @@ static int virtfn_add(struct pci_dev *de
if (reset)
__pci_reset_function(virtfn);
- pci_device_add(virtfn, virtfn->bus);
- mutex_unlock(&iov->dev->sriov->lock);
-
virtfn->physfn = pci_dev_get(dev);
virtfn->is_virtfn = 1;
+ pci_device_add(virtfn, virtfn->bus);
+ mutex_unlock(&iov->dev->sriov->lock);
+
rc = pci_bus_add_device(virtfn);
sprintf(buf, "virtfn%u", id);
rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf);
Index: linux-2.6/drivers/pci/pci-acpi.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci-acpi.c
+++ linux-2.6/drivers/pci/pci-acpi.c
@@ -321,6 +321,10 @@ static int acpi_pci_find_device(struct d
u64 addr;
pci_dev = to_pci_dev(dev);
+ /* don't mix vf with real pci device */
+ if (pci_dev->is_virtfn)
+ return -ENODEV;
+
/* Please ref to ACPI spec for the syntax of _ADR */
addr = (PCI_SLOT(pci_dev->devfn) << 16) | PCI_FUNC(pci_dev->devfn);
*handle = acpi_get_child(DEVICE_ACPI_HANDLE(dev->parent), addr);
next prev parent reply other threads:[~2013-05-14 2:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 2:28 [PATCH 0/7] PCI: fix pci dev add and remove sequence Yinghai Lu
2013-05-14 2:28 ` [PATCH 1/7] PCI: move back pci_proc_attach_devices calling Yinghai Lu
2013-05-14 2:28 ` [PATCH 2/7] PCI: move resources and bus_list releasing to pci_release_dev Yinghai Lu
2013-05-14 3:20 ` Yijing Wang
2013-05-14 3:56 ` Yinghai Lu
2013-05-14 6:02 ` Yijing Wang
2013-05-14 2:28 ` [PATCH 3/7] PCI: Detach driver in pci_stop_device Yinghai Lu
2013-05-14 2:28 ` [PATCH 4/7] PCI: Fix racing for pci device removing via sysfs Yinghai Lu
2013-05-16 7:52 ` Gu Zheng
2013-05-14 2:28 ` Yinghai Lu [this message]
2013-05-14 2:28 ` [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's Yinghai Lu
2013-05-14 8:58 ` Yan Burman
2013-05-14 15:43 ` Yinghai Lu
2013-05-16 4:00 ` Or Gerlitz
2013-05-16 4:39 ` Yinghai Lu
2013-05-16 4:56 ` Or Gerlitz
2013-05-16 17:53 ` Tejun Heo
2013-05-16 18:36 ` Yinghai Lu
2013-05-20 12:23 ` Or Gerlitz
2013-05-14 9:46 ` Perla, Sathya
2013-05-14 15:19 ` Yinghai Lu
2013-05-14 16:00 ` Alexander Duyck
2013-05-14 18:44 ` Yinghai Lu
2013-05-14 19:45 ` Alexander Duyck
2013-05-14 19:59 ` Yinghai Lu
2013-05-14 21:39 ` Alexander Duyck
2013-05-21 21:30 ` Don Dutile
2013-05-21 21:31 ` Don Dutile
2013-05-21 21:58 ` Alexander Duyck
2013-05-21 22:09 ` Don Dutile
2013-05-21 22:12 ` Alexander Duyck
2013-05-21 21:49 ` Michael S. Tsirkin
2013-05-21 22:01 ` Alexander Duyck
2013-05-21 22:11 ` Michael S. Tsirkin
2013-05-21 22:30 ` Alexander Duyck
2013-05-22 20:16 ` Or Gerlitz
2013-05-22 21:40 ` Don Dutile
2013-05-23 6:43 ` Or Gerlitz
2013-05-22 23:45 ` Ben Hutchings
2013-05-23 6:32 ` Or Gerlitz
2013-05-16 6:39 ` Michael S. Tsirkin
2013-05-14 2:28 ` [PATCH 7/7] PCI: use pf as dma_dev for vf that does not have func0 sibling Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368498506-25857-6-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).