From: Jiang Liu <liuj97@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>, Yinghai Lu <yinghai@kernel.org>
Cc: Jiang Liu <jiang.liu@huawei.com>, linux-pci@vger.kernel.org
Subject: [PATCH] PCI, IOV: fix a resource leakage on error recovery path
Date: Thu, 30 May 2013 12:31:33 +0800 [thread overview]
Message-ID: <1369888293-13387-1-git-send-email-jiang.liu@huawei.com> (raw)
In-Reply-To: <1369489718-25869-10-git-send-email-jiang.liu@huawei.com>
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
---
Hi Bjorn,
Could you please help to apply this small patch onto the
jiang-bus-lock-v3, which addresses a memory leakage issue pointed
out by Yinghai? Or you may fold it into " PCI, IOV: simplify IOV
implementation".
Thanks!
Gerry
---
drivers/pci/iov.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 5eb8165..458fb39 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -122,8 +122,9 @@ failed1:
pci_dev_put(dev);
mutex_lock(&iov->dev->sriov->lock);
pci_stop_and_remove_bus_device(virtfn);
- virtfn_remove_bus(dev->bus, bus);
failed0:
+ if (bus)
+ virtfn_remove_bus(dev->bus, bus);
mutex_unlock(&iov->dev->sriov->lock);
return rc;
--
1.8.1.2
next prev parent reply other threads:[~2013-05-30 4:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 13:48 [PATCH v3, part1 00/10] Prepare for introducing PCI bus lock interfaces Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 01/10] PCI: introduce pci_bus_{get|put}() to manage PCI bus reference count Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 02/10] PCI: Introduce pci_alloc_dev(struct pci_bus*) to replace alloc_pci_dev() Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 03/10] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead Jiang Liu
2013-06-05 20:07 ` Bjorn Helgaas
2013-06-06 16:16 ` Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 04/10] PCI: mark pci_scan_bus_parented() as __deprecated Jiang Liu
2013-05-31 20:12 ` Chris Metcalf
2013-06-05 20:04 ` Bjorn Helgaas
2013-06-06 16:32 ` Jiang Liu
2013-06-07 14:37 ` Konrad Rzeszutek Wilk
2013-06-07 15:11 ` Jiang Liu
2013-06-07 15:30 ` Jiang Liu
2013-06-07 20:37 ` Bjorn Helgaas
2013-05-25 13:48 ` [PATCH v3, part1 05/10] PCI, IA64: minor code clean up Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 06/10] PCI: make PCI host bridge/bus creating and destroying logic symmetric Jiang Liu
2013-06-05 20:14 ` Bjorn Helgaas
2013-06-06 17:10 ` [PATCH 1/2] PCI: fix a double free issue in pci_create_root_bus() error recovery path Jiang Liu
2013-06-08 1:42 ` Bjorn Helgaas
2013-06-06 17:10 ` [PATCH 2/2] PCI: make PCI host bridge/bus creating and destroying logic symmetric Jiang Liu
2013-06-06 20:01 ` Yinghai Lu
2013-06-08 1:51 ` Bjorn Helgaas
2013-06-08 7:01 ` Yinghai Lu
2013-06-14 23:53 ` Bjorn Helgaas
2013-06-15 1:46 ` Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 07/10] PCI, unicore, m68k: remove redundant call of pci_bus_add_devices() Jiang Liu
2013-06-05 21:31 ` Bjorn Helgaas
2013-06-06 6:54 ` Greg Ungerer
2013-05-25 13:48 ` [PATCH v3, part1 08/10] PCI, IOV: don't touch bus->is_added flag Jiang Liu
2013-05-25 13:48 ` [PATCH v3, part1 09/10] PCI, IOV: simplify IOV implementation Jiang Liu
2013-05-28 2:00 ` Yinghai Lu
2013-05-28 14:48 ` Liu Jiang
2013-05-30 4:31 ` Jiang Liu [this message]
2013-05-30 18:24 ` [PATCH] PCI, IOV: fix a resource leakage on error recovery path Bjorn Helgaas
2013-05-25 13:48 ` [PATCH v3, part1 10/10] PCI, IOV: hide remove and rescan sysfs interfaces for SR-IOV virtual functions Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369888293-13387-1-git-send-email-jiang.liu@huawei.com \
--to=liuj97@gmail.com \
--cc=bhelgaas@google.com \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).