linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yinghai Lu <yinghai@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Joerg Roedel <joro@8bytes.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Subject: [PATCH v3 16/27] x86, irq: Add ioapic_gsi_to_irq
Date: Fri,  7 Jun 2013 15:31:02 -0700	[thread overview]
Message-ID: <1370644273-10495-17-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1370644273-10495-1-git-send-email-yinghai@kernel.org>

For hot add ioapic, irq_base is not equal to gsi_base.
We need a way to do mapping between gsi and irq.

Also remove irq_to_gsi() that is confusing, just use that array
directly as only caller already check input irq before.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
 arch/x86/include/asm/io_apic.h |  1 +
 arch/x86/kernel/acpi/boot.c    | 22 +++++-----------------
 arch/x86/kernel/apic/io_apic.c | 29 ++++++++++++++++++++++++++++-
 3 files changed, 34 insertions(+), 18 deletions(-)

diff --git a/arch/x86/include/asm/io_apic.h b/arch/x86/include/asm/io_apic.h
index 8181fd8..02ac411 100644
--- a/arch/x86/include/asm/io_apic.h
+++ b/arch/x86/include/asm/io_apic.h
@@ -180,6 +180,7 @@ struct mp_ioapic_gsi{
 };
 extern struct mp_ioapic_gsi  mp_gsi_routing[];
 extern u32 gsi_top;
+int ioapic_gsi_to_irq(u32 gsi);
 int mp_find_ioapic(u32 gsi);
 int mp_find_ioapic_pin(int ioapic, u32 gsi);
 void __init mp_register_ioapic(int id, u32 address, u32 gsi_base);
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 230c8ea..7190d0d 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -111,6 +111,10 @@ static unsigned int gsi_to_irq(unsigned int gsi)
 		}
 	}
 
+#ifdef CONFIG_X86_IO_APIC
+	if (acpi_irq_model == ACPI_IRQ_MODEL_IOAPIC)
+		return ioapic_gsi_to_irq(gsi);
+#endif
 	/* Provide an identity mapping of gsi == irq
 	 * except on truly weird platforms that have
 	 * non isa irqs in the first 16 gsis.
@@ -123,22 +127,6 @@ static unsigned int gsi_to_irq(unsigned int gsi)
 	return irq;
 }
 
-static u32 irq_to_gsi(int irq)
-{
-	unsigned int gsi;
-
-	if (irq < NR_IRQS_LEGACY)
-		gsi = isa_irq_to_gsi[irq];
-	else if (irq < gsi_top)
-		gsi = irq;
-	else if (irq < (gsi_top + NR_IRQS_LEGACY))
-		gsi = irq - gsi_top;
-	else
-		gsi = 0xffffffff;
-
-	return gsi;
-}
-
 /*
  * Temporarily use the virtual area starting from FIX_IO_APIC_BASE_END,
  * to map the target physical address. The problem is that set_fixmap()
@@ -528,7 +516,7 @@ int acpi_isa_irq_to_gsi(unsigned isa_irq, u32 *gsi)
 {
 	if (isa_irq >= 16)
 		return -1;
-	*gsi = irq_to_gsi(isa_irq);
+	*gsi = isa_irq_to_gsi[isa_irq];
 	return 0;
 }
 
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 65863bd..7f95bbe 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1044,13 +1044,16 @@ static int pin_2_irq(int idx, int apic, int pin)
 
 	if (test_bit(bus, mp_bus_not_pci)) {
 		irq = mp_irqs[idx].srcbusirq;
-	} else {
+	} else if (gsi_cfg->gsi_base == gsi_cfg->irq_base) {
 		u32 gsi = gsi_cfg->gsi_base + pin;
 
 		if (gsi >= NR_IRQS_LEGACY)
 			irq = gsi;
 		else
 			irq = gsi_top + gsi;
+	} else {
+		/* hotadd ioapic */
+		irq = gsi_cfg->irq_base + pin;
 	}
 
 #ifdef CONFIG_X86_32
@@ -1476,6 +1479,30 @@ static void __init setup_IO_APIC_irqs(void)
 		__io_apic_setup_irqs(ioapic_idx);
 }
 
+int ioapic_gsi_to_irq(u32 gsi)
+{
+	int ioapic_idx = 0, irq = gsi;
+	struct mp_ioapic_gsi *gsi_cfg;
+
+	ioapic_idx = mp_find_ioapic(gsi);
+	if (ioapic_idx < 0)
+		return -1;
+
+	gsi_cfg = mp_ioapic_gsi_routing(ioapic_idx);
+	if (gsi_cfg->gsi_base == gsi_cfg->irq_base) {
+		if (gsi < NR_IRQS_LEGACY)
+			irq = gsi_top + gsi;
+	} else {
+		int pin = mp_find_ioapic_pin(ioapic_idx, gsi);
+
+		if (pin < 0)
+			return -1;
+		/* hotadd ioapic */
+		irq = gsi_cfg->irq_base + pin;
+	}
+
+	return irq;
+}
 /*
  * for the gsit that is not in first ioapic
  * but could not use acpi_register_gsi()
-- 
1.8.1.4


  parent reply	other threads:[~2013-06-07 22:31 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 22:30 [PATCH v3 00/27] x86, irq: support ioapic device hotplug Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 01/27] x86, irq: Change irq_remap_modify_chip_defaults to static Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 02/27] x86, irq: Modify irq chip once for irq remapping Yinghai Lu
2013-06-09 14:54   ` Sebastian Andrzej Siewior
2013-06-10 23:17     ` Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 03/27] x86, irq: Print out MSI/MSI-X clearly Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 04/27] x86, irq: Show MSI-X in /proc/interrupt Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 05/27] x86, irq: Make dmar_msi/hpet_msi irq_chip name consistent Yinghai Lu
2013-06-09 15:16   ` Sebastian Andrzej Siewior
2013-06-10 23:40     ` Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 06/27] ia64, irq: Add dummy create_irq_nr() Yinghai Lu
2013-06-09 15:22   ` Sebastian Andrzej Siewior
2013-06-10 23:41     ` Yinghai Lu
2013-06-11 21:52       ` Luck, Tony
2013-06-07 22:30 ` [PATCH v3 07/27] iommu, irq: Allocate irq_desc for dmar_msi with local node Yinghai Lu
2013-06-09 15:31   ` Sebastian Andrzej Siewior
2013-06-10 23:43     ` Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 08/27] x86, irq: kill create_irq() Yinghai Lu
2013-06-09 15:35   ` Sebastian Andrzej Siewior
2013-06-07 22:30 ` [PATCH v3 09/27] x86, irq: Convert irq_2_pin list to generic list Yinghai Lu
2013-06-09 15:52   ` Sebastian Andrzej Siewior
2013-06-07 22:30 ` [PATCH v3 10/27] genirq: Split __irq_reserve_irqs from irq_alloc_descs Yinghai Lu
2013-06-10 13:51   ` Alexander Gordeev
2013-06-10 19:16     ` Yinghai Lu
2013-06-10 19:42       ` Alexander Gordeev
2013-06-10 19:39   ` Thomas Gleixner
2013-06-10 23:55     ` Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 11/27] x86, irq: Add realloc_irq_and_cfg_at() Yinghai Lu
2013-06-09 19:13   ` Sebastian Andrzej Siewior
2013-06-10 20:13   ` Thomas Gleixner
2013-06-07 22:30 ` [PATCH v3 12/27] x86, irq: Move down arch_early_irq_init() Yinghai Lu
2013-06-07 22:30 ` [PATCH v3 13/27] x86, irq: Split out alloc_ioapic_save_registers() Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 14/27] xen, irq: call irq_realloc_desc_at() at first Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 15/27] x86, irq: pre-reserve irq range/realloc for booting path Yinghai Lu
2013-06-07 22:31 ` Yinghai Lu [this message]
2013-06-07 22:31 ` [PATCH v3 17/27] genirq: Bail out early in free_desc() Yinghai Lu
2013-06-10 20:43   ` Thomas Gleixner
2013-06-07 22:31 ` [PATCH v3 18/27] x86, irq: More strict checking about registering ioapic Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 19/27] x86, irq: Make mp_register_ioapic handle hot-added ioapic Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 20/27] x86, irq: Add mp_unregister_ioapic to handle hot-remove ioapic Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 21/27] x86, irq: Make ioapics loop skip blank slots Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 22/27] x86, ioapic: Find usable ioapic id for 64bit Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 23/27] x86: Move declaration for mp_register_ioapic() Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 24/27] PCI, x86: Make ioapic hotplug support built-in Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 25/27] PCI, x86, ACPI: Link acpi ioapic register to ioapic Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 26/27] PCI, x86, ACPI: Enable ioapic hotplug support with acpi host bridge Yinghai Lu
2013-06-07 22:31 ` [PATCH v3 27/27] PCI, x86, ACPI: get ioapic address from acpi device Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370644273-10495-17-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=sebastian@breakpoint.cc \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).