From: Jiang Liu <jiang.liu@huawei.com>
To: "Rafael J . Wysocki" <rjw@sisk.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>,
"Alexander E . Patrakov" <patrakov@gmail.com>
Cc: Jiang Liu <jiang.liu@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yijing Wang <wangyijing@huawei.com>, Jiang Liu <liuj97@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Shaohua Li <shaohua.li@intel.com>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: [BUGFIX 4/9] ACPI, DOCK: avoid initializing acpi_dock_notifier_list multiple times
Date: Fri, 14 Jun 2013 00:32:27 +0800 [thread overview]
Message-ID: <1371141152-9468-5-git-send-email-jiang.liu@huawei.com> (raw)
In-Reply-To: <1371141152-9468-1-git-send-email-jiang.liu@huawei.com>
Initialize acpi_dock_notifier_list from function acpi_dock_init()
instead of dock_add() to avoid initializing it multiple times.
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Cc: Shaohua Li <shaohua.li@intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/acpi/dock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 50e38b7..8e578aa 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -967,7 +967,6 @@ static int __init dock_add(acpi_handle handle)
spin_lock_init(&dock_station->dd_lock);
INIT_LIST_HEAD(&dock_station->sibling);
INIT_LIST_HEAD(&dock_station->hotplug_devices);
- ATOMIC_INIT_NOTIFIER_HEAD(&dock_notifier_list);
INIT_LIST_HEAD(&dock_station->dependent_devices);
/* we want the dock device to send uevents */
@@ -1038,6 +1037,7 @@ int __init acpi_dock_init(void)
return 0;
}
+ ATOMIC_INIT_NOTIFIER_HEAD(&dock_notifier_list);
register_acpi_bus_notifier(&dock_acpi_notifier);
pr_info(PREFIX "%s: %d docks/bays found\n",
ACPI_DOCK_DRIVER_DESCRIPTION, dock_station_count);
--
1.8.1.2
next prev parent reply other threads:[~2013-06-13 16:35 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 16:32 [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver Jiang Liu
2013-06-13 16:32 ` [BUGFIX 1/9] ACPI, DOCK: initialize dock subsystem before scanning PCI root buses Jiang Liu
2013-06-13 18:22 ` Rafael J. Wysocki
2013-06-13 18:24 ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 2/9] ACPIPHP: fix device destroying order issue when handling dock notification Jiang Liu
2013-06-13 19:59 ` Rafael J. Wysocki
2013-06-14 12:23 ` Rafael J. Wysocki
2013-06-14 12:30 ` Alexander E. Patrakov
2013-06-14 12:53 ` Rafael J. Wysocki
2013-06-14 16:58 ` Alexander E. Patrakov
2013-06-14 13:57 ` Jiang Liu
2013-06-14 14:12 ` Rafael J. Wysocki
2013-06-14 15:30 ` Jiang Liu
2013-06-14 23:12 ` Rafael J. Wysocki
2013-06-14 13:53 ` Jiang Liu
2013-06-14 14:05 ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 3/9] ACPI, DOCK: clean up unused module related code Jiang Liu
2013-06-13 18:26 ` Rafael J. Wysocki
2013-06-13 18:39 ` Rafael J. Wysocki
2013-06-14 14:04 ` Jiang Liu
2013-06-14 14:16 ` Rafael J. Wysocki
2013-06-13 16:32 ` Jiang Liu [this message]
2013-06-13 18:27 ` [BUGFIX 4/9] ACPI, DOCK: avoid initializing acpi_dock_notifier_list multiple times Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 5/9] ACPI, DOCK: kill redundant spin lock in dock device object Jiang Liu
2013-06-13 18:28 ` Rafael J. Wysocki
2013-06-14 14:05 ` Jiang Liu
2013-06-14 14:16 ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 6/9] ACPI, DOCK: mark initialization functions with __init Jiang Liu
2013-06-13 18:29 ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 7/9] ACPI, DOCK: simplify implementation of dock_create_acpi_device() Jiang Liu
2013-06-13 16:32 ` [BUGFIX 8/9] ACPI: introduce several helper functions Jiang Liu
2013-06-13 18:36 ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 9/9] ACPI: use new helper functions to simpilify code Jiang Liu
2013-06-13 17:34 ` Alexander E. Patrakov
2013-06-13 18:38 ` Rafael J. Wysocki
2013-06-13 17:43 ` [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver Alexander E. Patrakov
2013-06-13 18:26 ` Alexander E. Patrakov
2013-06-13 18:42 ` Yinghai Lu
2013-06-13 19:02 ` Rafael J. Wysocki
2013-06-13 19:08 ` Yinghai Lu
2013-06-14 2:06 ` Alexander E. Patrakov
2013-06-14 3:22 ` Yinghai Lu
2013-06-14 3:57 ` Alexander E. Patrakov
2013-06-14 2:09 ` Jiang Liu (Gerry)
2013-06-14 2:30 ` Yinghai Lu
2013-06-14 2:40 ` Alexander E. Patrakov
2013-06-14 2:51 ` Jiang Liu (Gerry)
2013-06-14 3:30 ` Yinghai Lu
2013-06-14 3:43 ` Yinghai Lu
2013-06-14 3:56 ` Jiang Liu (Gerry)
2013-06-14 3:53 ` Yinghai Lu
2013-06-14 4:07 ` Alexander E. Patrakov
2013-06-14 4:14 ` Jiang Liu (Gerry)
2013-06-14 4:43 ` Alexander E. Patrakov
2013-06-14 5:11 ` Jiang Liu (Gerry)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371141152-9468-5-git-send-email-jiang.liu@huawei.com \
--to=jiang.liu@huawei.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=patrakov@gmail.com \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).