linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@huawei.com>
To: "Rafael J . Wysocki" <rjw@sisk.pl>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Yinghai Lu <yinghai@kernel.org>,
	"Alexander E . Patrakov" <patrakov@gmail.com>
Cc: Jiang Liu <jiang.liu@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Yijing Wang <wangyijing@huawei.com>, Jiang Liu <liuj97@gmail.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shaohua Li <shaohua.li@intel.com>, Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org
Subject: [BUGFIX 7/9] ACPI, DOCK: simplify implementation of dock_create_acpi_device()
Date: Fri, 14 Jun 2013 00:32:30 +0800	[thread overview]
Message-ID: <1371141152-9468-8-git-send-email-jiang.liu@huawei.com> (raw)
In-Reply-To: <1371141152-9468-1-git-send-email-jiang.liu@huawei.com>

The return value of dock_create_acpi_device() is unused, so simplify
it by returning void.

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Cc: Shaohua Li <shaohua.li@intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/acpi/dock.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index da3314d..72cf97e 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -299,10 +299,8 @@ static int dock_present(struct dock_station *ds)
  *  handle if one does not exist already.  This should cause
  *  acpi to scan for drivers for the given devices, and call
  *  matching driver's add routine.
- *
- *  Returns a pointer to the acpi_device corresponding to the handle.
  */
-static struct acpi_device * dock_create_acpi_device(acpi_handle handle)
+static void dock_create_acpi_device(acpi_handle handle)
 {
 	struct acpi_device *device;
 	int ret;
@@ -315,10 +313,7 @@ static struct acpi_device * dock_create_acpi_device(acpi_handle handle)
 		ret = acpi_bus_scan(handle);
 		if (ret)
 			pr_debug("error adding bus, %x\n", -ret);
-
-		acpi_bus_get_device(handle, &device);
 	}
-	return device;
 }
 
 /**
-- 
1.8.1.2


  parent reply	other threads:[~2013-06-13 16:32 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13 16:32 [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver Jiang Liu
2013-06-13 16:32 ` [BUGFIX 1/9] ACPI, DOCK: initialize dock subsystem before scanning PCI root buses Jiang Liu
2013-06-13 18:22   ` Rafael J. Wysocki
2013-06-13 18:24   ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 2/9] ACPIPHP: fix device destroying order issue when handling dock notification Jiang Liu
2013-06-13 19:59   ` Rafael J. Wysocki
2013-06-14 12:23     ` Rafael J. Wysocki
2013-06-14 12:30       ` Alexander E. Patrakov
2013-06-14 12:53         ` Rafael J. Wysocki
2013-06-14 16:58           ` Alexander E. Patrakov
2013-06-14 13:57       ` Jiang Liu
2013-06-14 14:12         ` Rafael J. Wysocki
2013-06-14 15:30           ` Jiang Liu
2013-06-14 23:12             ` Rafael J. Wysocki
2013-06-14 13:53     ` Jiang Liu
2013-06-14 14:05       ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 3/9] ACPI, DOCK: clean up unused module related code Jiang Liu
2013-06-13 18:26   ` Rafael J. Wysocki
2013-06-13 18:39     ` Rafael J. Wysocki
2013-06-14 14:04     ` Jiang Liu
2013-06-14 14:16       ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 4/9] ACPI, DOCK: avoid initializing acpi_dock_notifier_list multiple times Jiang Liu
2013-06-13 18:27   ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 5/9] ACPI, DOCK: kill redundant spin lock in dock device object Jiang Liu
2013-06-13 18:28   ` Rafael J. Wysocki
2013-06-14 14:05     ` Jiang Liu
2013-06-14 14:16       ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 6/9] ACPI, DOCK: mark initialization functions with __init Jiang Liu
2013-06-13 18:29   ` Rafael J. Wysocki
2013-06-13 16:32 ` Jiang Liu [this message]
2013-06-13 16:32 ` [BUGFIX 8/9] ACPI: introduce several helper functions Jiang Liu
2013-06-13 18:36   ` Rafael J. Wysocki
2013-06-13 16:32 ` [BUGFIX 9/9] ACPI: use new helper functions to simpilify code Jiang Liu
2013-06-13 17:34   ` Alexander E. Patrakov
2013-06-13 18:38   ` Rafael J. Wysocki
2013-06-13 17:43 ` [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver Alexander E. Patrakov
2013-06-13 18:26   ` Alexander E. Patrakov
2013-06-13 18:42 ` Yinghai Lu
2013-06-13 19:02   ` Rafael J. Wysocki
2013-06-13 19:08     ` Yinghai Lu
2013-06-14  2:06   ` Alexander E. Patrakov
2013-06-14  3:22     ` Yinghai Lu
2013-06-14  3:57       ` Alexander E. Patrakov
2013-06-14  2:09   ` Jiang Liu (Gerry)
2013-06-14  2:30     ` Yinghai Lu
2013-06-14  2:40       ` Alexander E. Patrakov
2013-06-14  2:51       ` Jiang Liu (Gerry)
2013-06-14  3:30         ` Yinghai Lu
2013-06-14  3:43           ` Yinghai Lu
2013-06-14  3:56             ` Jiang Liu (Gerry)
2013-06-14  3:53           ` Yinghai Lu
2013-06-14  4:07         ` Alexander E. Patrakov
2013-06-14  4:14           ` Jiang Liu (Gerry)
2013-06-14  4:43             ` Alexander E. Patrakov
2013-06-14  5:11               ` Jiang Liu (Gerry)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371141152-9468-8-git-send-email-jiang.liu@huawei.com \
    --to=jiang.liu@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liuj97@gmail.com \
    --cc=patrakov@gmail.com \
    --cc=rjw@sisk.pl \
    --cc=shaohua.li@intel.com \
    --cc=wangyijing@huawei.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).