From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH v6 4/7] PCI: Introduce enable_local to prepare per root bus handling
Date: Mon, 22 Jul 2013 14:37:15 -0700 [thread overview]
Message-ID: <1374529038-14311-5-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1374529038-14311-1-git-send-email-yinghai@kernel.org>
Add enable_local to prepare assign unassigned resource
for per root bus.
Per Bjorn, separate it from big patch that handing assign_unssigned per root bus.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/setup-bus.c | 40 +++++++++++++++++++++-------------------
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 87687a5..eddc6e1 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -1354,9 +1354,9 @@ void __init pci_realloc_get_opt(char *str)
else if (!strncmp(str, "on", 2))
pci_realloc_enable = user_enabled;
}
-static bool __init pci_realloc_enabled(void)
+static bool __init pci_realloc_enabled(enum enable_type enable)
{
- return pci_realloc_enable >= user_enabled;
+ return enable >= user_enabled;
}
#if defined(CONFIG_PCI_IOV) && defined(CONFIG_PCI_REALLOC_ENABLE_AUTO)
@@ -1383,25 +1383,25 @@ static int __init check_unassigned_resources(struct pci_dev *dev, void *data)
return 0;
}
-static void __init pci_realloc_detect(void)
+static enum enable_type __init pci_realloc_detect(struct pci_bus *bus,
+ enum enable_type enable_local)
{
int unassigned = 0;
- struct pci_bus *bus;
- if (pci_realloc_enable != undefined)
- return;
+ if (enable_local != undefined)
+ return enable_local;
- list_for_each_entry(bus, &pci_root_buses, node) {
- pci_walk_bus(bus, check_unassigned_resources, &unassigned);
- if (unassigned) {
- pci_realloc_enable = auto_enabled;
- return;
- }
- }
+ pci_walk_bus(bus, check_unassigned_resources, &unassigned);
+ if (unassigned)
+ return auto_enabled;
+
+ return enable_local;
}
#else
-static void __init pci_realloc_detect(void)
+static enum enable_type __init pci_realloc_detect(struct pci_bus *bus,
+ enum enable_type enable_local)
{
+ return enable_local;
}
#endif
@@ -1424,10 +1424,12 @@ pci_assign_unassigned_resources(void)
unsigned long type_mask = IORESOURCE_IO | IORESOURCE_MEM |
IORESOURCE_PREFETCH;
int pci_try_num = 1;
+ enum enable_type enable_local = pci_realloc_enable;
+
+ list_for_each_entry(bus, &pci_root_buses, node)
+ enable_local = pci_realloc_detect(bus, enable_local);
- /* don't realloc if asked to do so */
- pci_realloc_detect();
- if (pci_realloc_enabled()) {
+ if (pci_realloc_enabled(enable_local)) {
int max_depth = pci_get_max_depth();
pci_try_num = max_depth + 1;
@@ -1459,9 +1461,9 @@ again:
goto enable_and_dump;
if (tried_times >= pci_try_num) {
- if (pci_realloc_enable == undefined)
+ if (enable_local == undefined)
printk(KERN_INFO "Some PCI device resources are unassigned, try booting with pci=realloc\n");
- else if (pci_realloc_enable == auto_enabled)
+ else if (enable_local == auto_enabled)
printk(KERN_INFO "Automatically enabled pci realloc, if you have problem, try booting with pci=realloc=off\n");
free_list(&fail_head);
--
1.8.1.4
next prev parent reply other threads:[~2013-07-22 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:37 [PATCH v6 0/7] PCI: Change assign unassigned resources per root bus bassis Yinghai Lu
2013-07-22 21:37 ` [PATCH v6 1/7] PCI: Don't use temp bus for pci_bus_release_bridge_resources Yinghai Lu
2013-07-22 21:37 ` [PATCH v6 2/7] PCI: Use pci_walk_bus to detect unassigned resources Yinghai Lu
2013-07-22 21:37 ` [PATCH v6 3/7] PCI: Check pci bus address for unassigned res Yinghai Lu
2013-07-22 21:37 ` Yinghai Lu [this message]
2013-07-22 21:37 ` [PATCH v6 5/7] PCI: Split pci_assign_unassigned_resources to per root bus Yinghai Lu
2013-07-22 21:37 ` [PATCH v6 6/7] PCI: Enable pci bridge when it is needed Yinghai Lu
2013-07-22 21:37 ` [PATCH v6 7/7] PCI: Retry assign unassigned resources for hotadd root bus Yinghai Lu
2013-07-24 22:03 ` [PATCH v6 0/7] PCI: Change assign unassigned resources per root bus bassis Bjorn Helgaas
2013-07-24 23:12 ` Rafael J. Wysocki
2013-07-25 13:38 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374529038-14311-5-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).