linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Jason Cooper <jason@lakedaemon.net>,
	linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH v6 07/14] PCI: tegra: set up PADS_REFCLK_CFG1
Date: Fri,  9 Aug 2013 16:49:25 +0200	[thread overview]
Message-ID: <1376059772-16669-8-git-send-email-treding@nvidia.com> (raw)
In-Reply-To: <1376059772-16669-1-git-send-email-treding@nvidia.com>

From: Stephen Warren <swarren@nvidia.com>

The registers PADS_REFCLK_CFG are an array of 16-bit data, one entry per
PCIe root port. For Tegra30, we therefore need to write a 3rd entry in
this array. Doing so mays the mini-PCIe slot on Beaver operate correctly.

While we're at it, add some #defines to partially document the fields
within these 16-bit values.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/host/pci-tegra.c | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 75607c7..ad95c40 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -195,6 +195,25 @@
 #define PADS_REFCLK_CFG0			0x000000C8
 #define PADS_REFCLK_CFG1			0x000000CC
 
+/*
+ * Fields in PADS_REFCLK_CFG*. Those registers form an array of 16-bit
+ * entries, one entry per PCIe port. These field definitions and desired
+ * values aren't in the TRM, but do come from NVIDIA.
+ */
+#define PADS_REFCLK_CFG_TERM_SHIFT		2  /* 6:2 */
+#define PADS_REFCLK_CFG_E_TERM_SHIFT		7
+#define PADS_REFCLK_CFG_PREDI_SHIFT		8  /* 11:8 */
+#define PADS_REFCLK_CFG_DRVI_SHIFT		12 /* 15:12 */
+
+/* Default value provided by HW engineering is 0xfa5c */
+#define PADS_REFCLK_CFG_VALUE \
+	( \
+		(0x17 << PADS_REFCLK_CFG_TERM_SHIFT)   | \
+		(0    << PADS_REFCLK_CFG_E_TERM_SHIFT) | \
+		(0xa  << PADS_REFCLK_CFG_PREDI_SHIFT)  | \
+		(0xf  << PADS_REFCLK_CFG_DRVI_SHIFT)     \
+	)
+
 struct tegra_msi {
 	struct msi_chip chip;
 	DECLARE_BITMAP(used, INT_PCI_MSI_NR);
@@ -808,11 +827,11 @@ static int tegra_pcie_enable_controller(struct tegra_pcie *pcie)
 	value |= PADS_PLL_CTL_RST_B4SM;
 	pads_writel(pcie, value, soc->pads_pll_ctl);
 
-	/*
-	 * Hack, set the clock voltage to the DEFAULT provided by hw folks.
-	 * This doesn't exist in the documentation.
-	 */
-	pads_writel(pcie, 0xfa5cfa5c, PADS_REFCLK_CFG0);
+	/* Configure the reference clock driver */
+	value = PADS_REFCLK_CFG_VALUE | (PADS_REFCLK_CFG_VALUE << 16);
+	pads_writel(pcie, value, PADS_REFCLK_CFG0);
+	if (soc->num_ports > 2)
+		pads_writel(pcie, PADS_REFCLK_CFG_VALUE, PADS_REFCLK_CFG1);
 
 	/* wait for the PLL to lock */
 	timeout = 300;
-- 
1.8.3.4


  parent reply	other threads:[~2013-08-09 14:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 14:49 [PATCH v6 00/14] Rewrite Tegra PCIe driver Thierry Reding
2013-08-09 14:49 ` [PATCH v6 01/14] PCI: tegra: Move PCIe driver to drivers/pci/host Thierry Reding
2013-08-09 14:49 ` [PATCH v6 02/14] ARM: tegra: tamonten: Add PCIe support Thierry Reding
2013-08-09 14:49 ` [PATCH v6 03/14] ARM: tegra: tec: " Thierry Reding
2013-08-09 14:49 ` [PATCH v6 04/14] ARM: tegra: harmony: Initialize PCIe from DT Thierry Reding
2013-08-09 14:49 ` [PATCH v6 05/14] ARM: tegra: trimslice: " Thierry Reding
2013-08-09 14:49 ` [PATCH v6 06/14] PCI: tegra: Add Tegra 30 PCIe support Thierry Reding
2013-08-09 14:49 ` Thierry Reding [this message]
2013-08-09 14:49 ` [PATCH v6 08/14] ARM: tegra: Add Tegra30 " Thierry Reding
2013-08-09 14:49 ` [PATCH v6 09/14] ARM: tegra: Enable PCIe controller on Cardhu Thierry Reding
2013-08-09 14:49 ` [PATCH v6 10/14] ARM: tegra: Enable PCIe controller on Beaver Thierry Reding
2013-08-09 14:49 ` [PATCH v6 11/14] ARM: tegra: Fix Beaver's PCIe lane configuration Thierry Reding
2013-08-09 14:49 ` [PATCH v6 12/14] ARM: tegra: Update default configuration (PCIe) Thierry Reding
2013-08-09 14:49 ` [PATCH v6 13/14] ARM: dts: tegra: Increase prefetchable PCI memory space Thierry Reding
2013-08-09 14:49 ` [PATCH v6 14/14] MAINTAINERS: Add myself as Tegra PCIe maintainer Thierry Reding
2013-08-09 14:56   ` Bjorn Helgaas
2013-08-09 15:08 ` [PATCH v6 00/14] Rewrite Tegra PCIe driver Jason Cooper
2013-08-12 16:16   ` Thierry Reding
2013-08-12 16:22     ` Jason Cooper
2013-08-12 21:19 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376059772-16669-8-git-send-email-treding@nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).