From: Veaceslav Falico <vfalico@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Veaceslav Falico <vfalico@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs()
Date: Tue, 17 Sep 2013 03:47:42 +0200 [thread overview]
Message-ID: <1379382464-7920-2-git-send-email-vfalico@redhat.com> (raw)
In-Reply-To: <1379382464-7920-1-git-send-email-vfalico@redhat.com>
Before trying to kobject_init_and_add(), we add a reference to pdev via
pci_dev_get(pdev). However, if it fails to init and/or add the kobject, we
don't return it back - even on out_unroll.
Fix this by adding pci_dev_put(pdev) before going to unrolling section.
CC: Bjorn Helgaas <bhelgaas@google.com>
CC: linux-pci@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
drivers/pci/msi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index d5f90d6..14bf578 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -534,8 +534,10 @@ static int populate_msi_sysfs(struct pci_dev *pdev)
pci_dev_get(pdev);
ret = kobject_init_and_add(kobj, &msi_irq_ktype, NULL,
"%u", entry->irq);
- if (ret)
+ if (ret) {
+ pci_dev_put(pdev);
goto out_unroll;
+ }
count++;
}
--
1.8.4
next prev parent reply other threads:[~2013-09-17 1:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 1:47 [PATCH 0/3] msi: fix kobject/sysfs removal from msi_list Veaceslav Falico
2013-09-17 1:47 ` Veaceslav Falico [this message]
2013-09-25 21:08 ` [PATCH 1/3] msi: add forgotten pci_dev_put(pdev) to populate_msi_sysfs() Bjorn Helgaas
2013-09-25 21:30 ` Bjorn Helgaas
2013-09-25 22:09 ` Veaceslav Falico
2013-09-25 23:23 ` Neil Horman
2013-09-25 23:35 ` Bjorn Helgaas
2013-09-26 9:27 ` Veaceslav Falico
2013-09-26 12:25 ` Veaceslav Falico
2013-09-26 14:07 ` Veaceslav Falico
2013-09-26 22:16 ` Bjorn Helgaas
2013-09-26 23:05 ` Veaceslav Falico
2013-09-26 14:40 ` Neil Horman
2013-09-17 1:47 ` [PATCH 2/3] msi: always unregister ->msi_kset within free_msi_irqs() Veaceslav Falico
2013-09-17 1:47 ` [PATCH 3/3] msi: free msi_desc entry only after we've released the kobject Veaceslav Falico
2013-09-25 21:34 ` Bjorn Helgaas
2013-09-25 22:12 ` Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379382464-7920-2-git-send-email-vfalico@redhat.com \
--to=vfalico@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).