From: Veaceslav Falico <vfalico@redhat.com>
To: linux-pci@vger.kernel.org
Cc: Veaceslav Falico <vfalico@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Neil Horman <nhorman@tuxdriver.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] msi: remove useless kobject_del() in free_msi_irqs()
Date: Thu, 26 Sep 2013 16:11:15 +0200 [thread overview]
Message-ID: <1380204675-18238-3-git-send-email-vfalico@redhat.com> (raw)
In-Reply-To: <1380204675-18238-1-git-send-email-vfalico@redhat.com>
We only need to kobject_put() on removal (which will, eventually, call
kobject_del()). kobject_del() should be implicitly used only on circular
references (per documentation), however it's not the case here.
CC: Bjorn Helgaas <bhelgaas@google.com>
CC: Neil Horman <nhorman@tuxdriver.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: linux-pci@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
drivers/pci/msi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index dafda2b..d62c468 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -384,12 +384,10 @@ static void free_msi_irqs(struct pci_dev *dev)
* kobject->release will take care of freeing the entry via
* msi_kobj_release().
*/
- if (entry->kobj.parent) {
- kobject_del(&entry->kobj);
+ if (entry->kobj.parent)
kobject_put(&entry->kobj);
- } else {
+ else
kfree(entry);
- }
}
if (dev->msi_kset) {
--
1.8.4
next prev parent reply other threads:[~2013-09-26 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:11 [PATCH v2 1/3] pci: remove redundant pci_dev_get/put() on kobject (un)register Veaceslav Falico
2013-09-26 14:11 ` [PATCH v2 2/3] msi: always unregister ->msi_kset within free_msi_irqs() Veaceslav Falico
2013-09-26 15:17 ` Neil Horman
2013-09-26 14:11 ` Veaceslav Falico [this message]
2013-09-26 15:16 ` [PATCH v2 1/3] pci: remove redundant pci_dev_get/put() on kobject (un)register Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380204675-18238-3-git-send-email-vfalico@redhat.com \
--to=vfalico@redhat.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).