Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Lian Minghuan-b31939 <B31939@freescale.com>
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
	<linuxppc-dev@lists.ozlabs.org>,
	Zang Roy-R61911 <r61911@freescale.com>,
	Kumar Gala <galak@kernel.crashing.org>,
	Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/2] pci: fsl: rework PCI driver compatible with Layerscape
Date: Fri, 27 Sep 2013 11:47:33 -0500	[thread overview]
Message-ID: <1380300453.24959.389.camel@snotra.buserror.net> (raw)
In-Reply-To: <52456C0C.2020504@freescale.com>

On Fri, 2013-09-27 at 19:29 +0800, Lian Minghuan-b31939 wrote:
> Hi All,
> 
> Can anyone comment on my code or help to pick up?

Please break it up into multiple patches, each with one logical change
that is individually explained.  It will be much easier to review that
way.

-Scott




  reply	other threads:[~2013-09-27 16:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 11:02 [PATCH 1/2] pci: fsl: derive the common PCI driver to drivers/pci/host Minghuan Lian
2013-09-18 11:02 ` [PATCH 2/2] pci: fsl: rework PCI driver compatible with Layerscape Minghuan Lian
2013-09-27 11:29   ` Lian Minghuan-b31939
2013-09-27 16:47     ` Scott Wood [this message]
2013-09-27 16:54   ` Scott Wood
2013-09-29 11:51     ` Lian Minghuan-b31939
2013-09-30 22:50       ` Scott Wood
2013-09-29 23:56   ` Timur Tabi
2013-09-30  1:52     ` Lian Minghuan-b31939
2013-09-30 22:41       ` Scott Wood
2013-10-01  1:19       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380300453.24959.389.camel@snotra.buserror.net \
    --to=scottwood@freescale.com \
    --cc=B31939@freescale.com \
    --cc=Minghuan.Lian@freescale.com \
    --cc=bhelgaas@google.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=r61911@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox