From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d
Date: Sat, 28 Sep 2013 08:00:03 +1000 [thread overview]
Message-ID: <1380319203.27811.44.camel@pasglop> (raw)
In-Reply-To: <CAE9FiQXXvkfTak6oEpUog_RYs_Gwpdji7N5UJ=R11Q61==N97A@mail.gmail.com>
On Fri, 2013-09-27 at 14:54 -0700, Yinghai Lu wrote:
> On Fri, Sep 27, 2013 at 2:46 PM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
>
> > Wouldn't it be better to simply have pci_enable_device() always set bus
> > master on a bridge? I don't see any case where it makes sense to have
> > an enabled bridge without the master bit set on it...
>
> Do you mean attached?
That's an option. I was thinking making pci_enable_device() itself
enable bus master on a bridge but yes, you approach should work.
I'm digging a bit more to figure out what went wrong in the
pcie port driver since that's interesting in its own right and I'll then
test your patch which I think is a more robust approach.
Cheers,
Ben.
next prev parent reply other threads:[~2013-09-27 22:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 8:28 Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d Benjamin Herrenschmidt
2013-09-27 16:01 ` Yinghai Lu
2013-09-27 17:10 ` Linus Torvalds
2013-09-27 21:46 ` Benjamin Herrenschmidt
2013-09-27 21:54 ` Yinghai Lu
2013-09-27 22:00 ` Benjamin Herrenschmidt [this message]
2013-09-27 22:38 ` Benjamin Herrenschmidt
2013-09-27 22:56 ` Yinghai Lu
2013-09-27 23:19 ` Benjamin Herrenschmidt
2013-09-27 23:44 ` Yinghai Lu
2013-09-28 3:05 ` Benjamin Herrenschmidt
2013-09-28 20:13 ` [PATCH] PCI: Workaround missing pci_set_master in pci drivers Yinghai Lu
2013-09-29 22:41 ` Theodore Ts'o
2013-09-29 22:46 ` Linus Torvalds
2013-09-29 22:57 ` Theodore Ts'o
2013-10-03 22:06 ` Bjorn Helgaas
2013-10-03 23:35 ` Yinghai Lu
2013-10-04 15:55 ` Bjorn Helgaas
2013-11-04 12:44 ` Paul Bolle
2013-11-05 23:26 ` Bjorn Helgaas
2013-09-28 20:14 ` Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d Yinghai Lu
2013-09-29 0:40 ` Rafael J. Wysocki
2013-09-27 17:44 ` Yinghai Lu
2013-09-27 22:15 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380319203.27811.44.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).