From: "Bjørn Erik Nilsen" <ben@datarespons.no>
To: jg1.han@samsung.com
Cc: marex@denx.de, pratyush.anand@gmail.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, kishon@ti.com, Mohit.KUMAR@st.com,
ajay.khandelwal@st.com, tharvey@gateworks.com,
Eric.Nelson@boundarydevices.com, troy.kisky@boundarydevices.com,
"Bjørn Erik Nilsen" <ben@datarespons.no>
Subject: [PATCH v5 2/2] PCI: designware: Remove redundant call to pci_write_config
Date: Fri, 29 Nov 2013 14:35:25 +0100 [thread overview]
Message-ID: <1385732125-28630-3-git-send-email-ben@datarespons.no> (raw)
In-Reply-To: <1385732125-28630-1-git-send-email-ben@datarespons.no>
write_msi_msg() does exactly the same so there is no need
to explicitly call pci_write_config and do the same twice.
Signed-off-by: Bjørn Erik Nilsen <ben@datarespons.no>
---
drivers/pci/host/pcie-designware.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index 61345a1..212b8b6 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -345,10 +345,10 @@ static int dw_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev,
if (irq < 0)
return irq;
- msg_ctr &= ~PCI_MSI_FLAGS_QSIZE;
- msg_ctr |= msgvec << 4;
- pci_write_config_word(pdev, desc->msi_attrib.pos + PCI_MSI_FLAGS,
- msg_ctr);
+ /*
+ * write_msi_msg() will update PCI_MSI_FLAGS so there is
+ * no need to explicitly call pci_write_config.
+ */
desc->msi_attrib.multiple = msgvec;
msg.address_lo = virt_to_phys((void *)pp->msi_data);
--
1.8.4.4
next prev parent reply other threads:[~2013-11-29 13:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528a1bb6.6a88700a.28c9.ffff824aSMTPIN_ADDED_MISSING@mx.google.com>
[not found] ` <CAErSpo4TbUuq0wb06JV9Xchmcjsk9q3cm7+XO-dOSiJAAhXPMA@mail.gmail.com>
2013-11-18 21:02 ` Kernel oops from pci_disable_msi Bjorn Helgaas
2013-11-18 23:11 ` Jingoo Han
2013-11-19 11:24 ` Marek Vasut
[not found] ` <1384861142.3682.1.camel@bnilsen-HP-EliteBook-8760w>
[not found] ` <cmu-lmtpd-19155-1384861370-13@frontend1.mail.m-online.net>
2013-11-19 22:01 ` Marek Vasut
[not found] ` <cmu-lmtpd-1612-1384936883-21@frontend1.mail.m-online.net>
2013-11-20 10:30 ` Marek Vasut
[not found] ` <cmu-lmtpd-21237-1384948548-21@frontend1.mail.m-online.net>
2013-11-20 12:02 ` Marek Vasut
[not found] ` <cmu-lmtpd-23243-1384949805-3@frontend1.mail.m-online.net>
2013-11-20 13:57 ` Marek Vasut
[not found] ` <1385036087.3945.28.camel@bnilsen-HP>
[not found] ` <1385039987.6020.5.camel@bnilsen-HP>
[not found] ` <16.79.22145.6305E825@epmailin9.samsung.com>
2013-11-22 8:48 ` Jingoo Han
[not found] ` <1385118399.3944.32.camel@bnilsen-HP>
[not found] ` <7D.78.31634.B838F825@epmailin2.samsung.com>
2013-11-26 11:21 ` [PATCH] " Jingoo Han
[not found] ` <cmu-lmtpd-32538-1385137032-0@frontend1.mail.m-online.net>
2013-11-26 21:19 ` Marek Vasut
[not found] ` <cmu-lmtpd-17794-1385506605-2@frontend1.mail.m-online.net>
2013-11-26 23:05 ` Marek Vasut
2013-11-27 9:46 ` Marek Vasut
[not found] ` <cmu-lmtpd-20073-1385566822-1@frontend1.mail.m-online.net>
2013-11-27 19:05 ` [PATCH v4] " Marek Vasut
[not found] ` <C7.DF.00504.D1216925@epmailin4.samsung.com>
2013-11-29 7:37 ` Jingoo Han
2013-11-29 13:35 ` [PATCH v5 0/2] " Bjørn Erik Nilsen
2013-11-29 13:35 ` [PATCH v5 1/2] PCI: designware: Fix crash in dw_msi_teardown_irq Bjørn Erik Nilsen
2013-11-29 14:32 ` Marek Vasut
[not found] ` <cmu-lmtpd-25244-1385737839-23@frontend1.mail.m-online.net>
2013-11-29 15:36 ` Marek Vasut
[not found] ` <cmu-lmtpd-32360-1385742114-0@frontend1.mail.m-online.net>
2013-11-29 17:02 ` Marek Vasut
[not found] ` <cmu-lmtpd-8418-1385750273-5@frontend1.mail.m-online.net>
2013-12-02 8:10 ` Marek Vasut
2013-11-29 13:35 ` Bjørn Erik Nilsen [this message]
2013-12-05 1:52 ` [PATCH v5 0/2] Kernel oops from pci_disable_msi Jingoo Han
2013-12-05 2:18 ` Marek Vasut
2013-12-05 2:24 ` Jingoo Han
2013-12-05 4:07 ` Mohit KUMAR DCG
2013-12-09 20:43 ` Bjorn Helgaas
[not found] ` <52a632f0.e42c980a.3d86.ffff8faeSMTPIN_ADDED_MISSING@mx.google.com>
2013-12-09 21:21 ` Bjorn Helgaas
[not found] ` <52a63678.4902980a.6fd7.ffffa2b9SMTPIN_ADDED_MISSING@mx.google.com>
2013-12-09 22:27 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385732125-28630-3-git-send-email-ben@datarespons.no \
--to=ben@datarespons.no \
--cc=Eric.Nelson@boundarydevices.com \
--cc=Mohit.KUMAR@st.com \
--cc=ajay.khandelwal@st.com \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=marex@denx.de \
--cc=pratyush.anand@gmail.com \
--cc=tharvey@gateworks.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).