From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jean Delvare <jdelvare@suse.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] PCI/portdrv: Set master earlier
Date: Mon, 09 Dec 2013 14:07:28 +1100 [thread overview]
Message-ID: <1386558448.5159.10.camel@pasglop> (raw)
In-Reply-To: <CAE9FiQWGWPVO0W5e9qtbMx7PTEKDq8kUPi1RRT8tucMEy7prYw@mail.gmail.com>
On Sat, 2013-12-07 at 19:26 -0800, Yinghai Lu wrote:
> BenH mentioned that get_port_device_capability have some problem on
> powerpc and will return null.
Well, it has problems on anything that doesn't have ACPI :-)
I don't care what the "right" fix is but we need to makes sure nobody
does a pci_enable_device() on a bridge and doesn't also enable bus
master, otherwise the bridge bus master will never be set. This is what
was happening an breaking us.
Ben.
next prev parent reply other threads:[~2013-12-09 3:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 14:33 [PATCH] PCI/portdrv: Set master earlier Jean Delvare
2013-12-07 22:23 ` Bjorn Helgaas
2013-12-08 3:26 ` Yinghai Lu
2013-12-09 3:07 ` Benjamin Herrenschmidt [this message]
2013-12-17 0:53 ` Bjorn Helgaas
2013-12-08 13:09 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386558448.5159.10.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=jdelvare@suse.de \
--cc=linux-pci@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).