From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: bhelgaas@google.com, jesse.brandeburg@gmail.com,
linux-pci@vger.kernel.org, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com,
linux-kernel@vger.kernel.org, bjorn.helgaas@hp.com
Subject: Re: [net-next] pci_regs.h: Add PCI bus link speed and width defines
Date: Fri, 03 Jan 2014 17:27:39 -0800 [thread overview]
Message-ID: <1388798859.2275.5.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20140103.193008.684316024702680161.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
On Fri, 2014-01-03 at 19:30 -0500, David Miller wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> Date: Fri, 3 Jan 2014 17:00:42 -0700
>
> > On Fri, Jan 3, 2014 at 4:56 PM, David Miller <davem@davemloft.net> wrote:
> >> From: Bjorn Helgaas <bhelgaas@google.com>
> >> Date: Fri, 3 Jan 2014 15:15:57 -0700
> >>
> >>> However, I do raise my eyebrows a bit at drivers that poke around in
> >>> the PCIe capability. I would prefer to have PCI core interfaces that
> >>> handle that instead. But I haven't seen Jeff's changes yet.
> >>
> >> The changes just read the link status to interpret the speed at which
> >> the PCI-E link is running at.
> >
> > Several drivers want to do that. It'd be nice if somebody abstracted
> > that out somehow. Jacob added pcie_get_minimum_link() which is
> > similar. But maybe Jeff needs something more in this case.
> >
> > In any case, it's not a blocker for this patch.
>
> Ok.
>
> Jeff, please merge this via the Intel submission process and don't forget
> to add Bjorn's ACK.
>
> Thanks.
Ok, will do. What do you want to do with the current series of patches
(mainly the ixgbe LER patches) on my tree? I know that there is a
thread going on between Joe Perches and Mark, but it sounded like Mark
is working on a follow-on patch to address Joe's concerns.
Guess I want to know if I leave my tree alone for you to pull or toss
the current pull request series and get the i40e series applied.
Cheers,
Jeff
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-01-04 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1388234173-31654-1-git-send-email-jeffrey.t.kirsher@intel.com>
[not found] ` <20140102.192133.1585340046080167370.davem@davemloft.net>
2014-01-03 21:53 ` [net-next] pci_regs.h: Add PCI bus link speed and width defines Jesse Brandeburg
2014-01-03 22:15 ` Bjorn Helgaas
2014-01-03 23:56 ` David Miller
2014-01-04 0:00 ` Bjorn Helgaas
2014-01-04 0:30 ` David Miller
2014-01-04 1:27 ` Jeff Kirsher [this message]
2014-01-04 1:48 ` David Miller
2014-01-04 1:51 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388798859.2275.5.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bhelgaas@google.com \
--cc=bjorn.helgaas@hp.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).