linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sander Eikelenboom <linux@eikelenboom.it>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Tony Luck <tony.luck@intel.com>, Dave Airlie <airlied@redhat.com>,
	Eiichiro Oiwa <eiichiro.oiwa.nm@hitachi.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sander Eikelenboom <linux@eikelenboom.it>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"linux-kernel @ vger . kernel . org"
	<linux-kernel@vger.kernel.org>,
	"linux-pci @ vger . kernel . org" <linux-pci@vger.kernel.org>,
	linux-ia64@vger.kernel.org
Subject: [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents it from reading it's own rom. It will get the content of the shadowrom at C000 instead, which is of the primary VGA card and the driver of the secondary card will bail out.
Date: Fri, 31 Jan 2014 10:28:22 +0100	[thread overview]
Message-ID: <1391160503-11122-1-git-send-email-linux@eikelenboom.it> (raw)
In-Reply-To: <20140130000831.GJ16825@google.com>

Hi Bjorn / Tony,

I fixed up ia64 as well and brought it inline again with the x86 code,
but i don't have a ia64 machine, so that part is untested.
Perhaps Tony is able to review/test it ?

Sander



Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary
prevents it from reading it's own rom. It will get the content of the shadowrom
at C000 instead, which is of the primary VGA card and the driver of the
secondary card will bail out.

Fix this by checking if the arch code or vga-arbitration has already
determined the vga_default_device, if so only apply the fix to this
primary video device and let the comment reflect this.

v2:
    - Fix pci_fixup_video both in x86 and ia64


Sander Eikelenboom (1):
  Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the
    primary     prevents it from reading it's own rom. It will get the
    content of the shadowrom     at C000 instead, which is of the
    primary VGA card and the driver of the     secondary card will bail
    out.

 arch/ia64/pci/fixup.c |   24 +++++++++++++-----------
 arch/x86/pci/fixup.c  |   18 ++++++++++--------
 2 files changed, 23 insertions(+), 19 deletions(-)

-- 
1.7.10.4


  reply	other threads:[~2014-01-31  9:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1389499841-6097-1-git-send-email-linux@eikelenboom.it>
     [not found] ` <XNM1$9$0$4$$3$3$7$A$9006858U52d4d109@hitachi.com>
     [not found]   ` <6310129377.20140114162641@eikelenboom.it>
     [not found]     ` <XNM1$9$0$4$$3$3$7$A$9006860U52d614ca@hitachi.com>
2014-01-15 19:36       ` In "pci_fixup_video" check if this is or should be the primary video devi Sander Eikelenboom
2014-01-15 21:50         ` Bjorn Helgaas
2014-01-15 22:25           ` Sander Eikelenboom
     [not found]             ` <XNM1$9$0$4$$3$3$7$A$9006862U52d758ed@hitachi.com>
2014-01-16 13:19               ` In "pci_fixup_video" check if this is or should be the primary video d Bjorn Helgaas
2014-01-30  0:08             ` In "pci_fixup_video" check if this is or should be the primary video devi Bjorn Helgaas
2014-01-31  9:28               ` Sander Eikelenboom [this message]
2014-01-31  9:28                 ` [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents it from reading it's own rom. It will get the content of the shadowrom at C000 instead, which is of the primary VGA card and the driver of the secondary card will bail out Sander Eikelenboom
2014-02-03 14:52                 ` Konrad Rzeszutek Wilk
2014-02-07 11:03                   ` Sander Eikelenboom
2014-02-13  9:48                   ` Sander Eikelenboom
2014-02-14 20:26                     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391160503-11122-1-git-send-email-linux@eikelenboom.it \
    --to=linux@eikelenboom.it \
    --cc=airlied@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=eiichiro.oiwa.nm@hitachi.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).