From: Lucas Stach <l.stach@pengutronix.de>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Richard Zhu <r65037@freescale.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: adjust the interrupt list in order to support MSI
Date: Wed, 26 Feb 2014 17:57:05 +0100 [thread overview]
Message-ID: <1393433825.4692.2.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <20140226163402.GF29659@e106331-lin.cambridge.arm.com>
Am Mittwoch, den 26.02.2014, 16:34 +0000 schrieb Mark Rutland:
> On Wed, Feb 26, 2014 at 10:27:17AM +0000, Lucas Stach wrote:
> > From: Juergen Beisert <jbe@pengutronix.de>
> >
> > Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx6qdl.dtsi | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> > index fb28b2ecb1db..aeccbb114fc5 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -126,7 +126,8 @@
> > 0x81000000 0 0 0x01f80000 0 0x00010000 /* downstream I/O */
> > 0x82000000 0 0x01000000 0x01000000 0 0x00f00000>; /* non-prefetchable memory */
> > num-lanes = <1>;
> > - interrupts = <0 123 0x04>;
> > + /* inta intb intc intd/msi */
> > + interrupts = <0 123 0x04>, <0 122 0x04>, <0 121 0x04>, <0 120 0x04>;
>
> This seems to be a "fsl,imx6q-pcie", "snps,dw-pcie" device.
>
> In Documentation/devicetree/bindings/pci/designware-pcie.txt I only see 3
> interrupts listed.
>
> The fourth interrupt must be documented.
>
> Do the first three correspond to those in the documentation?
>
Urgh, seems Samsung and FSL do all the glue a lot different. The IRQs
seem to be different and the same holds true for the clocks.
I think we should split the Documentation here to avoid further
confusion. Will send a patch.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2014-02-26 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 10:27 [PATCH v2 1/2] ARM: dts: imx6: adjust the interrupt list in order to support MSI Lucas Stach
2014-02-26 10:27 ` [PATCH v2 2/2] PCI: imx6: add support for MSI Lucas Stach
2014-02-26 16:36 ` Mark Rutland
2014-02-26 14:01 ` [PATCH v2 1/2] ARM: dts: imx6: adjust the interrupt list in order to support MSI Shawn Guo
2014-02-26 16:34 ` Mark Rutland
2014-02-26 16:57 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393433825.4692.2.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=r65037@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).