From: Lucas Stach <l.stach@pengutronix.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
Jingoo Han <jg1.han@samsung.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Simon Horman <horms@verge.net.au>,
Shawn Guo <shawn.guo@linaro.org>, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
kernel@pengutronix.de
Subject: Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible
Date: Thu, 06 Mar 2014 18:39:15 +0100 [thread overview]
Message-ID: <1394127555.4582.1.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <5318B232.2020507@wwwdotorg.org>
Am Donnerstag, den 06.03.2014, 10:36 -0700 schrieb Stephen Warren:
> On 03/05/2014 06:25 AM, Lucas Stach wrote:
> > This is the recommended method of doing the IRQ
> > mapping. For old devicetrees we fall back to the
> > previous practice.
>
> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> I tested both with and without patch 1/6, and the PCIe-based NIC on
> Beaver worked fine either way. Without patch 1/6, I do see:
>
> pci 0000:00:01.0: of_irq_parse_pci() failed with rc=-22
>
> ... but that seems reasonable given that the DT that of_irq_parse_pci()
> parses is missing, and did correctly trigger the fallback path, so
> everything still worked.
Yes, this should be normal. It spits this error for old DTs, but keeps
doing the right thing. I'm not sure if we should downgrade this to info
or dbg.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-03-06 17:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 13:25 [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
2014-03-05 13:25 ` [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 21:55 ` Stephen Warren
2014-03-06 9:33 ` Lucas Stach
2014-03-06 17:41 ` Stephen Warren
2014-03-05 13:25 ` [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible Lucas Stach
2014-03-06 17:36 ` Stephen Warren
2014-03-06 17:39 ` Lucas Stach [this message]
2014-03-07 0:25 ` Arnd Bergmann
2014-03-07 3:31 ` Jingoo Han
2014-04-11 17:40 ` Srikanth Thokala
2014-04-11 20:41 ` Jason Gunthorpe
2014-04-14 10:56 ` Srikanth Thokala
2014-04-04 16:55 ` Bjorn Helgaas
2014-04-15 10:07 ` Lucas Stach
2014-04-15 18:30 ` Bjorn Helgaas
2014-04-16 8:20 ` Lucas Stach
2014-04-16 16:29 ` Bjorn Helgaas
2014-03-05 13:25 ` [PATCH v2 3/6] PCI: rcar: " Lucas Stach
2014-03-06 4:12 ` Simon Horman
2014-04-04 17:01 ` Bjorn Helgaas
2014-04-07 9:30 ` [PATCH v2 rebased] " Lucas Stach
2014-03-05 13:25 ` [PATCH v2 4/6] ARM: dts: exynos5440: fix PCIe interrupt mapping Lucas Stach
2014-03-06 2:38 ` Jingoo Han
2014-03-05 13:25 ` [PATCH v2 5/6] ARM: dts: imx6: add PCIe interrupt mapping properties Lucas Stach
2014-03-10 3:09 ` Shawn Guo
2014-03-05 13:25 ` [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible Lucas Stach
2014-03-05 18:42 ` Jason Gunthorpe
2014-04-04 17:03 ` Bjorn Helgaas
2014-04-04 17:05 ` Bjorn Helgaas
2014-04-07 8:38 ` Lucas Stach
2014-04-07 9:13 ` Jingoo Han
2014-03-06 2:47 ` Jingoo Han
2014-03-06 15:33 ` Marek Vasut
2014-03-13 17:41 ` Tim Harvey
2014-03-28 15:47 ` [PATCH v2 0/6] PCI irq mapping fixes and cleanups Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394127555.4582.1.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=jg1.han@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).