* [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
@ 2014-03-28 19:13 Ryan Desfosses
2014-03-30 20:59 ` Ryan
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Desfosses @ 2014-03-28 19:13 UTC (permalink / raw)
To: linux-pci; +Cc: linux-kernel, Ryan Desfosses
change made to resolve following checkpatch message:
drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index fdbc294..a50d542 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
* Given a PCI bus, returns the highest PCI bus number present in the set
* including the given PCI bus and its list of child PCI buses.
*/
-unsigned char pci_bus_max_busnr(struct pci_bus* bus)
+unsigned char pci_bus_max_busnr(struct pci_bus *bus)
{
struct list_head *tmp;
unsigned char max, n;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
2014-03-28 19:13 Ryan Desfosses
@ 2014-03-30 20:59 ` Ryan
2014-03-31 9:49 ` Liviu Dudau
0 siblings, 1 reply; 6+ messages in thread
From: Ryan @ 2014-03-30 20:59 UTC (permalink / raw)
To: linux-pci; +Cc: linux-kernel
Hello,
This is my first patch. I'm looking for feedback pertaining to my
submission that way I can submit more patches correctly in the future.
Any constructive feedback is welcome.
I have one question in particular regarding the 'Sign by' section in the
git commit message. Am I suppose to add a 'Sign by' line for myself or
is that for the core kernel team?
Thank you for time and feedback,
Ryan
On 03/28/2014 03:13 PM, Ryan Desfosses wrote:
> change made to resolve following checkpatch message:
> drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index fdbc294..a50d542 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
> * Given a PCI bus, returns the highest PCI bus number present in the set
> * including the given PCI bus and its list of child PCI buses.
> */
> -unsigned char pci_bus_max_busnr(struct pci_bus* bus)
> +unsigned char pci_bus_max_busnr(struct pci_bus *bus)
> {
> struct list_head *tmp;
> unsigned char max, n;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
2014-03-30 20:59 ` Ryan
@ 2014-03-31 9:49 ` Liviu Dudau
0 siblings, 0 replies; 6+ messages in thread
From: Liviu Dudau @ 2014-03-31 9:49 UTC (permalink / raw)
To: Ryan; +Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
On Sun, Mar 30, 2014 at 09:59:28PM +0100, Ryan wrote:
> Hello,
>
> This is my first patch. I'm looking for feedback pertaining to my
> submission that way I can submit more patches correctly in the future.
> Any constructive feedback is welcome.
Documentation/SubmittingPatches is always a good source of good practices.
>
> I have one question in particular regarding the 'Sign by' section in the
> git commit message. Am I suppose to add a 'Sign by' line for myself or
> is that for the core kernel team?
You can find Section 12 of the file mentioned above relevant. Signed-off-by
is a way of telling others that you have the right to release the code that
you are posting *and* (IMHO) will take responsability for the modifications you
make (i.e. if someone will complain about things breaking up you will fix them).
Best regards,
Liviu
>
> Thank you for time and feedback,
> Ryan
>
> On 03/28/2014 03:13 PM, Ryan Desfosses wrote:
> > change made to resolve following checkpatch message:
> > drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
> > ---
> > drivers/pci/pci.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index fdbc294..a50d542 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
> > * Given a PCI bus, returns the highest PCI bus number present in the set
> > * including the given PCI bus and its list of child PCI buses.
> > */
> > -unsigned char pci_bus_max_busnr(struct pci_bus* bus)
> > +unsigned char pci_bus_max_busnr(struct pci_bus *bus)
> > {
> > struct list_head *tmp;
> > unsigned char max, n;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
@ 2014-03-31 16:47 Ryan Desfosses
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Desfosses @ 2014-03-31 16:47 UTC (permalink / raw)
To: trivial; +Cc: linux-kernel, linux-pci, Ryan Desfosses
change made to resolve following checkpatch message:
drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index fdbc294..a50d542 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
* Given a PCI bus, returns the highest PCI bus number present in the set
* including the given PCI bus and its list of child PCI buses.
*/
-unsigned char pci_bus_max_busnr(struct pci_bus* bus)
+unsigned char pci_bus_max_busnr(struct pci_bus *bus)
{
struct list_head *tmp;
unsigned char max, n;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
@ 2014-04-04 21:23 Ryan Desfosses
2014-04-04 21:44 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Desfosses @ 2014-04-04 21:23 UTC (permalink / raw)
To: bhelgaas; +Cc: trivial, linux-kernel, linux-pci, Ryan Desfosses
change made to resolve following checkpatch message:
drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
branch: Linux 3.14-rc8
Signed-off-by: Ryan Desfosses <ryan@desfo.org>
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index fdbc294..a50d542 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
* Given a PCI bus, returns the highest PCI bus number present in the set
* including the given PCI bus and its list of child PCI buses.
*/
-unsigned char pci_bus_max_busnr(struct pci_bus* bus)
+unsigned char pci_bus_max_busnr(struct pci_bus *bus)
{
struct list_head *tmp;
unsigned char max, n;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'
2014-04-04 21:23 Ryan Desfosses
@ 2014-04-04 21:44 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2014-04-04 21:44 UTC (permalink / raw)
To: Ryan Desfosses; +Cc: trivial, linux-kernel, linux-pci
On Fri, Apr 04, 2014 at 05:23:34PM -0400, Ryan Desfosses wrote:
> change made to resolve following checkpatch message:
> drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
> branch: Linux 3.14-rc8
>
> Signed-off-by: Ryan Desfosses <ryan@desfo.org>
Applied (folded into your other patch), thanks!
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index fdbc294..a50d542 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
> * Given a PCI bus, returns the highest PCI bus number present in the set
> * including the given PCI bus and its list of child PCI buses.
> */
> -unsigned char pci_bus_max_busnr(struct pci_bus* bus)
> +unsigned char pci_bus_max_busnr(struct pci_bus *bus)
> {
> struct list_head *tmp;
> unsigned char max, n;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-04 21:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 16:47 [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus' Ryan Desfosses
-- strict thread matches above, loose matches on Subject: below --
2014-04-04 21:23 Ryan Desfosses
2014-04-04 21:44 ` Bjorn Helgaas
2014-03-28 19:13 Ryan Desfosses
2014-03-30 20:59 ` Ryan
2014-03-31 9:49 ` Liviu Dudau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).