linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Woodhouse, David" <david.woodhouse@intel.com>
To: "davidlohr@hp.com" <davidlohr@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bhe@redhat.com" <bhe@redhat.com>,
	"jiang.liu@linux.intel.com" <jiang.liu@linux.intel.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"James.Bottomley@hansenpartnership.com"
	<James.Bottomley@hansenpartnership.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"scameron@beardog.cce.hp.com" <scameron@beardog.cce.hp.com>
Subject: Re: hpsa driver bug crack kernel down!
Date: Thu, 10 Apr 2014 16:30:01 +0000	[thread overview]
Message-ID: <1397147399.1308.44.camel@i7.infradead.org> (raw)
In-Reply-To: <1397146781.2608.46.camel@buesod1.americas.hpqcorp.net>

[-- Attachment #1: Type: text/plain, Size: 2211 bytes --]

On Thu, 2014-04-10 at 09:19 -0700, Davidlohr Bueso wrote:
> > > > > >> > > > > dmar: DMAR:[DMA Read] Request device [02:00.0] fault addr 7f61e000
> > 
> > That "Present bit in context entry is clear" fault means that we have
> > not set up *any* mappings for this PCI device… on this IOMMU.
> > 
> > > > Yes, specifically (finally done bisecting):
> > > > 
> > > > commit 2e45528930388658603ea24d49cf52867b928d3e
> > > > Author: Jiang Liu <jiang.liu@linux.intel.com>
> > > > Date:   Wed Feb 19 14:07:36 2014 +0800
> > > > 
> > > >     iommu/vt-d: Unify the way to process DMAR device scope array
> > 
> > This commit is about how we decide which IOMMU a given PCI device is
> > attached to.
> > 
> > Thus, my first guess would be that we are quite happily setting up the
> > requested DMA maps on the *wrong* IOMMU, and then taking faults when the
> > device actually tries to do DMA.
> > 
> > However, I'm not 100% convinced of that. The fault address looks
> > suspiciously like a true physical address, not a virtual bus address of
> > the type that we'd normally allocate for a dma_map_* operation. Those
> > would start at 0xfffff000 and work downwards, typically.
> > 
> > Do you have 'iommu=pt' on the kernel command line? 
> 
> No.
> 
> > Can I see the full
> > dmesg as this system boots, and also a copy of the DMAR table?
> 
> Attaching a dmesg from one of the kernels that boots. It doesn't appear
> to have much of the related information... 

It shows us that the address 0x7f61e000 is in an E820-reserved region,
and that there's and RMRR covering that region for an unspecified PCI
device, but that's going to be the hpsa.

So if isn't just a simple case of us assigning this device to the wrong
IOMMU, *perhaps* it's that we lose the RMRR when the driver takes
control of the device. RMRRs are generally expected to be a boot-time
thing, for things like legacy keyboard/mouse emulation via USB. Using
them while the system is *active* is... horrid. We've often not quite
handled that right.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3437 bytes --]

  reply	other threads:[~2014-04-10 16:32 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140409023935.GE11839@dhcp-16-105.nay.redhat.com>
     [not found] ` <1397083799.2608.20.camel@buesod1.americas.hpqcorp.net>
     [not found]   ` <1397084904.9519.62.camel@dabdike>
     [not found]     ` <1397085044.9519.63.camel@dabdike>
     [not found]       ` <1397086817.2608.25.camel@buesod1.americas.hpqcorp.net>
2014-04-09 23:50         ` hpsa driver bug crack kernel down! James Bottomley
2014-04-10  0:19           ` Davidlohr Bueso
2014-04-10  4:03             ` Bjorn Helgaas
2014-04-10  6:32               ` Davidlohr Bueso
2014-04-10  7:15                 ` Joerg Roedel
2014-04-10  8:46                   ` Woodhouse, David
2014-04-10 15:14                     ` Bjorn Helgaas
2014-04-10 15:34                       ` Woodhouse, David
2014-04-10 15:36                       ` Linda Knippers
2014-04-10 16:19                     ` Davidlohr Bueso
2014-04-10 16:30                       ` Woodhouse, David [this message]
2014-04-11  9:18                       ` Woodhouse, David
2014-04-14 15:45                         ` Davidlohr Bueso
2014-04-14 16:19                           ` Jiang Liu
2014-04-14 16:44                             ` Davidlohr Bueso
2014-04-14 16:47                               ` Davidlohr Bueso
2014-04-14 17:03                                 ` Woodhouse, David
2014-04-16 13:37                                   ` joro
2014-04-16 13:58                                     ` Woodhouse, David
2014-04-16 14:13                                       ` joro
2014-04-14  7:01                       ` Jiang Liu
2014-04-14  8:57                       ` Jiang Liu
2014-04-14 18:08                         ` Davidlohr Bueso
2014-04-10 20:45                 ` scameron
2014-04-10 23:17                   ` Shuah Khan
2014-04-11  8:57                     ` David Woodhouse
2014-04-10  8:34               ` Jiang Liu
2014-04-10 15:54                 ` Davidlohr Bueso
2014-04-10 16:02                 ` Davidlohr Bueso
2014-04-11  1:34                 ` Baoquan He
2014-04-11  3:14                 ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397147399.1308.44.camel@i7.infradead.org \
    --to=david.woodhouse@intel.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=davidlohr@hp.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scameron@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).