linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Shuah Khan <shuahkhan@gmail.com>
Cc: scameron@beardog.cce.hp.com, Davidlohr Bueso <davidlohr@hp.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Baoquan He <bhe@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	"open list:INTEL IOMMU (VT-d)" <iommu@lists.linux-foundation.org>,
	Jiang Liu <jiang.liu@linux.intel.com>
Subject: Re: hpsa driver bug crack kernel down!
Date: Fri, 11 Apr 2014 09:57:09 +0100	[thread overview]
Message-ID: <1397206629.19944.54.camel@shinybook.infradead.org> (raw)
In-Reply-To: <CAKocOONaqGAaiesf_MUFXEOMDtX8R8kYuPQYAxLBfth7nAx3Jg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

On Thu, 2014-04-10 at 17:17 -0600, Shuah Khan wrote:
> This smells very much like the problem that was solved couple of years
> ago for SI domain. It is likely that path is broken with the DMAR
> device scope array change. Please take a look to see if the following
> no longer occurs. Looks like BIOS could be expecting this RMRR to be
> still mapped.
> 
>                /*
>                  * We want to prevent any device associated with an RMRR from
>                  * getting placed into the SI Domain. This is done because
>                  * problems exist when devices are moved in and out of domains
>                  * and their respective RMRR info is lost. We exempt USB devices
>                  * from this process due to their usage of RMRRs that are known
>                  * to not be needed after BIOS hand-off to OS.
>                  */
>                 if (device_has_rmrr(dev) &&
>                     (pdev->class >> 8) != PCI_CLASS_SERIAL_USB)
>                         return 0;

Yeah, I'd be inclined to agree.... although I've tested with graphics
*since* these patches. That's another case where we need to preserve the
RMRR mapping after the driver takes over — and it *was* working.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]

  reply	other threads:[~2014-04-11  8:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140409023935.GE11839@dhcp-16-105.nay.redhat.com>
     [not found] ` <1397083799.2608.20.camel@buesod1.americas.hpqcorp.net>
     [not found]   ` <1397084904.9519.62.camel@dabdike>
     [not found]     ` <1397085044.9519.63.camel@dabdike>
     [not found]       ` <1397086817.2608.25.camel@buesod1.americas.hpqcorp.net>
2014-04-09 23:50         ` hpsa driver bug crack kernel down! James Bottomley
2014-04-10  0:19           ` Davidlohr Bueso
2014-04-10  4:03             ` Bjorn Helgaas
2014-04-10  6:32               ` Davidlohr Bueso
2014-04-10  7:15                 ` Joerg Roedel
2014-04-10  8:46                   ` Woodhouse, David
2014-04-10 15:14                     ` Bjorn Helgaas
2014-04-10 15:34                       ` Woodhouse, David
2014-04-10 15:36                       ` Linda Knippers
2014-04-10 16:19                     ` Davidlohr Bueso
2014-04-10 16:30                       ` Woodhouse, David
2014-04-11  9:18                       ` Woodhouse, David
2014-04-14 15:45                         ` Davidlohr Bueso
2014-04-14 16:19                           ` Jiang Liu
2014-04-14 16:44                             ` Davidlohr Bueso
2014-04-14 16:47                               ` Davidlohr Bueso
2014-04-14 17:03                                 ` Woodhouse, David
2014-04-16 13:37                                   ` joro
2014-04-16 13:58                                     ` Woodhouse, David
2014-04-16 14:13                                       ` joro
2014-04-14  7:01                       ` Jiang Liu
2014-04-14  8:57                       ` Jiang Liu
2014-04-14 18:08                         ` Davidlohr Bueso
2014-04-10 20:45                 ` scameron
2014-04-10 23:17                   ` Shuah Khan
2014-04-11  8:57                     ` David Woodhouse [this message]
2014-04-10  8:34               ` Jiang Liu
2014-04-10 15:54                 ` Davidlohr Bueso
2014-04-10 16:02                 ` Davidlohr Bueso
2014-04-11  1:34                 ` Baoquan He
2014-04-11  3:14                 ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397206629.19944.54.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=davidlohr@hp.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scameron@beardog.cce.hp.com \
    --cc=shuahkhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).