From: Fabio Estevam <festevam@gmail.com>
To: thomas.petazzoni@free-electrons.com
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
jg1.han@samsung.com, Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH v2] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type
Date: Tue, 29 Apr 2014 00:24:56 -0300 [thread overview]
Message-ID: <1398741896-5953-1-git-send-email-festevam@gmail.com> (raw)
From: Fabio Estevam <fabio.estevam@freescale.com>
Fix the following build warning that happens when building multi_v7_defconfig
with CONFIG_ARM_LPAE=y:
drivers/pci/host/pci-mvebu.c:334:5: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'phys_addr_t' [-Wformat=]
Fix the warning by using '%pa' to printing 'phys_addr_t' type. While at it,
also use the more standard notation [mem 0x - 0x] for memory region.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- use the [mem 0x - 0x] notation
drivers/pci/host/pci-mvebu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index e384e25..df57a6a 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -330,8 +330,8 @@ static void mvebu_pcie_add_windows(struct mvebu_pcie_port *port,
sz, remap);
if (ret) {
dev_err(&port->pcie->pdev->dev,
- "Could not create MBus window at 0x%x, size 0x%x: %d\n",
- base, sz, ret);
+ "Could not create MBus window at [mem %pa - %pa] :%d\n",
+ &base, &base + sz, ret);
mvebu_pcie_del_windows(port, base - size_mapped,
size_mapped);
return;
--
1.8.3.2
next reply other threads:[~2014-04-29 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 3:24 Fabio Estevam [this message]
2014-04-29 5:35 ` [PATCH v2] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type Jingoo Han
2014-04-29 5:45 ` Thomas Petazzoni
2014-04-29 5:53 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398741896-5953-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).