From: Jiang Liu <jiang.liu@linux.intel.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Grant Likely <grant.likely@linaro.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Yinghai Lu <yinghai@kernel.org>,
x86@kernel.org, Len Brown <lenb@kernel.org>,
David Cohen <david.a.cohen@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Jiang Liu <jiang.liu@linux.intel.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Joerg Roedel <joro@8bytes.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org,
"H. Peter Anvin" <hpa@linux.intel.com>,
sfi-devel@simplefirmware.org
Subject: [Patch Part1 V2 27/29] x86, irq, SFI: use common irqdomain map interface to program IOAPIC pins
Date: Tue, 20 May 2014 00:23:11 +0800 [thread overview]
Message-ID: <1400516594-11544-28-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1400516594-11544-1-git-send-email-jiang.liu@linux.intel.com>
Refine SFI to use common irqdomain map interface to program IOAPIC pins,
so we can unify the callsite to progam IOAPIC pins.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
arch/x86/pci/intel_mid_pci.c | 17 +++++++----------
arch/x86/platform/intel-mid/sfi.c | 18 +++++++++---------
arch/x86/platform/sfi/sfi.c | 4 +++-
3 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 84b9d672843d..f6f3de857baa 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/arch/x86/pci/intel_mid_pci.c
@@ -208,23 +208,20 @@ static int pci_write(struct pci_bus *bus, unsigned int devfn, int where,
static int intel_mid_pci_irq_enable(struct pci_dev *dev)
{
- u8 pin;
- struct io_apic_irq_attr irq_attr;
-
- pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
+ int ioapic, polarity;
/*
* MRST only have IOAPIC, the PCI irq lines are 1:1 mapped to
* IOAPIC RTE entries, so we just enable RTE for the device.
*/
- irq_attr.ioapic = mp_find_ioapic(dev->irq);
- irq_attr.ioapic_pin = dev->irq;
- irq_attr.trigger = 1; /* level */
+ ioapic = mp_find_ioapic(dev->irq);
if (intel_mid_identify_cpu() == INTEL_MID_CPU_CHIP_TANGIER)
- irq_attr.polarity = 0; /* active high */
+ polarity = 0; /* active high */
else
- irq_attr.polarity = 1; /* active low */
- io_apic_set_pci_routing(&dev->dev, dev->irq, &irq_attr);
+ polarity = 1; /* active low */
+ if (mp_set_pin_attr(ioapic, dev->irq, 1, polarity, dev_to_node(dev)))
+ return -EBUSY;
+ mp_map_gsi_to_irq(dev->irq, 1);
return 0;
}
diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c
index 994c40bd7cb7..3fe5c23ba1c5 100644
--- a/arch/x86/platform/intel-mid/sfi.c
+++ b/arch/x86/platform/intel-mid/sfi.c
@@ -434,6 +434,7 @@ static int __init sfi_parse_devs(struct sfi_table_header *table)
struct devs_id *dev = NULL;
int num, i;
int ioapic;
+ int polarity;
struct io_apic_irq_attr irq_attr;
sb = (struct sfi_table_simple *)table;
@@ -450,30 +451,29 @@ static int __init sfi_parse_devs(struct sfi_table_header *table)
*/
ioapic = mp_find_ioapic(irq);
if (ioapic >= 0) {
- irq_attr.ioapic = ioapic;
- irq_attr.ioapic_pin = irq;
- irq_attr.trigger = 1;
if (intel_mid_identify_cpu() ==
INTEL_MID_CPU_CHIP_TANGIER) {
if (!strncmp(pentry->name,
"r69001-ts-i2c", 13))
/* active low */
- irq_attr.polarity = 1;
+ polarity = 1;
else if (!strncmp(pentry->name,
"synaptics_3202", 14))
/* active low */
- irq_attr.polarity = 1;
+ polarity = 1;
else if (irq == 41)
/* fast_int_1 */
- irq_attr.polarity = 1;
+ polarity = 1;
else
/* active high */
- irq_attr.polarity = 0;
+ polarity = 0;
} else {
/* PNW and CLV go with active low */
- irq_attr.polarity = 1;
+ polarity = 1;
}
- io_apic_set_pci_routing(NULL, irq, &irq_attr);
+ if (mp_set_pin_attr(ioapic, irq, 1, polarity, NUMA_NO_NODE))
+ return -EBUSY;
+ mp_map_gsi_to_irq(dev->irq, 1);
}
} else {
irq = 0; /* No irq */
diff --git a/arch/x86/platform/sfi/sfi.c b/arch/x86/platform/sfi/sfi.c
index 2c3522dfa05d..91e5046efae9 100644
--- a/arch/x86/platform/sfi/sfi.c
+++ b/arch/x86/platform/sfi/sfi.c
@@ -71,7 +71,9 @@ static int __init sfi_parse_cpus(struct sfi_table_header *table)
#endif /* CONFIG_X86_LOCAL_APIC */
#ifdef CONFIG_X86_IO_APIC
-static struct irq_domain_ops sfi_ioapic_irqdomain_ops;
+static struct irq_domain_ops sfi_ioapic_irqdomain_ops = {
+ .map = mp_irqdomain_map,
+};
static struct irq_domain *sfi_ioapic_create_irqdomain(int ioapic, void *arg)
{
--
1.7.10.4
next prev parent reply other threads:[~2014-05-19 16:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 16:22 [Patch Part1 V2 00/29] use irqdomain to dynamically allocate IRQ for IOAPIC Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 01/29] x86, irq: update high address field when updating affinity for MSI IRQ Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 02/29] genirq, trivial: improve documentation to match current implementation Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 03/29] x86, mpparse: use pr_lvl() helper utilities to replace printk(KERN_LVL) Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 04/29] x86, mpparse: simplify arch/x86/include/asm/mpspec.h Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 05/29] x86, PCI, ACPI: use kmalloc_node() to optimize for performance Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 06/29] x86, acpi, irq: kill static function irq_to_gsi() Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 07/29] x86, ACPI, trivial: minor improvements to arch/x86/kernel/acpi/boot.c Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 08/29] x86, ACPI, irq: enhance error handling in function acpi_register_gsi() Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 09/29] x86, ACPI, irq: fix possible eror in GSI to IRQ mapping for legacy IRQ Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 10/29] x86, irq, trivial: minor improvements of IRQ related code Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 11/29] x86, ioapic: kill unused global variable timer_through_8259 Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 12/29] x86, ioapic: kill static variable nr_irqs_gsi Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 13/29] x86, ioapic: introduce helper utilities to walk ioapics and pins Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 14/29] x86, ioapic: use irq_cfg() instead of irq_get_chip_data() for better readability Jiang Liu
2014-05-19 16:22 ` [Patch Part1 V2 15/29] x86, irq: reorganize IO_APIC_get_PCI_irq_vector() to prepare for irqdomain Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 16/29] x86, irq: introduce some helper utilities to improve readability Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 17/29] x86, ACPI, irq: consolidate algorithm of mapping (ioapic, pin) to IRQ number Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 18/29] x86, irq: introduce mechanisms to support dynamically allocate IRQ for IOAPIC Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 19/29] x86, irq: enhance mp_register_ioapic() to support irqdomain Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 20/29] x86, ACPI, irq: provide basic irqdomain support Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 21/29] x86, mpparse, " Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 22/29] x86, devicetree, irq: use common mechanism to support irqdomain Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 23/29] x86, SFI, irq: provide basic irqdomain support Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 24/29] x86, irq: introduce two helper functions to support irqdomain map operation Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 25/29] x86, irq, ACPI: use common irqdomain map interface to program IOAPIC pins Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 26/29] x86, irq, mpparse: " Jiang Liu
2014-05-19 16:23 ` Jiang Liu [this message]
2014-05-19 16:23 ` [Patch Part1 V2 28/29] x86, irq, devicetree: " Jiang Liu
2014-05-19 16:23 ` [Patch Part1 V2 29/29] x86, irq: clean up unused IOAPIC interface Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400516594-11544-28-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=david.a.cohen@linux.intel.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sfi-devel@simplefirmware.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).