From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1BDC433F5 for ; Wed, 10 Nov 2021 16:05:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59FAC61152 for ; Wed, 10 Nov 2021 16:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231679AbhKJQIK (ORCPT ); Wed, 10 Nov 2021 11:08:10 -0500 Received: from office.oderland.com ([91.201.60.5]:39890 "EHLO office.oderland.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231536AbhKJQIK (ORCPT ); Wed, 10 Nov 2021 11:08:10 -0500 Received: from [193.180.18.161] (port=49720 helo=[10.137.0.14]) by office.oderland.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mkq6C-00DWE5-K1; Wed, 10 Nov 2021 17:05:20 +0100 Message-ID: <14006026-de76-41d6-f4dc-cdbdd5817dc7@oderland.se> Date: Wed, 10 Nov 2021 17:05:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Subject: Re: [PATCH v2] PCI/MSI: Move non-mask check back into low level accessors Content-Language: en-US From: Josef Johansson To: Thomas Gleixner Cc: boris.ostrovsky@oracle.com, helgaas@kernel.org, jgross@suse.com, linux-pci@vger.kernel.org, maz@kernel.org, xen-devel@lists.xenproject.org, Jason Andryuk , David Woodhouse References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se> <20211025012503.33172-1-jandryuk@gmail.com> <87fssmg8k4.ffs@tglx> <87cznqg5k8.ffs@tglx> <89d6c2f4-4d00-972f-e434-cb1839e78598@oderland.se> <5b3d4653-0cdf-e098-0a4a-3c5c3ae3977b@oderland.se> <87k0ho6ctu.ffs@tglx> <87h7cs6cri.ffs@tglx> <87pmr92xek.ffs@tglx> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - office.oderland.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - oderland.se X-Get-Message-Sender-Via: office.oderland.com: authenticated_id: josjoh@oderland.se X-Authenticated-Sender: office.oderland.com: josjoh@oderland.se Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 11/10/21 14:31, Josef Johansson wrote: > On 11/9/21 15:53, Thomas Gleixner wrote: >> On Thu, Nov 04 2021 at 00:27, Thomas Gleixner wrote: >>> >>> - if (!entry->msi_attrib.is_virtual) { >>> + if (!entry->msi_attrib.can_mask) { >> Groan. I'm a moron. This obviously needs to be >> >> if (entry->msi_attrib.can_mask) { > I will compile and check. Thanks for being thorough. This worked as well. >>> addr = pci_msix_desc_addr(entry); >>> entry->msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL); >>> }