From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jiang Liu To: Benjamin Herrenschmidt , Thomas Gleixner , Grant Likely , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Randy Dunlap , Yinghai Lu , Jiang Liu Cc: Konrad Rzeszutek Wilk , Andrew Morton , Tony Luck , Joerg Roedel , Paul Gortmaker , Greg Kroah-Hartman , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [RFC Patch V2 08/16] PCI: kill wrong warning message in pcieport driver Date: Tue, 17 Jun 2014 13:29:47 +0800 Message-Id: <1402982995-13747-9-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1402982995-13747-1-git-send-email-jiang.liu@linux.intel.com> References: <1402982995-13747-1-git-send-email-jiang.liu@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: For hot-added PCIe ports, it always generates a warning message on x86 platforms when binding to pcieport driver as: "device [8086:0e0b] has invalid IRQ; check vendor BIOS". It's due to that we check pci_dev->irq before actually allocating IRQ number for the PCI device: if (!dev->irq && dev->pin) { dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " "check vendor BIOS\n", dev->vendor, dev->device); } status = pcie_port_device_register(dev); -->pci_enable_device(dev); -->pci_enable_device_flags() -->do_pci_enable_device() -->pcibios_enable_device() -->pcibios_enable_irq() This warning message isn't generated for PCIe ports present at boot time because x86 arch code has called acpi_pci_irq_enable() in pci_acpi_init() for each PCI device for safety. Signed-off-by: Jiang Liu --- drivers/pci/pcie/portdrv_pci.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c index 0d8fdc48e642..0e35f9670066 100644 --- a/drivers/pci/pcie/portdrv_pci.c +++ b/drivers/pci/pcie/portdrv_pci.c @@ -203,10 +203,6 @@ static int pcie_portdrv_probe(struct pci_dev *dev, (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM))) return -ENODEV; - if (!dev->irq && dev->pin) { - dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; " - "check vendor BIOS\n", dev->vendor, dev->device); - } status = pcie_port_device_register(dev); if (status) return status; -- 1.7.10.4