From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cpsmtpb-ews02.kpnxchange.com ([213.75.39.5]:63837 "EHLO cpsmtpb-ews02.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934161AbaFTHlz (ORCPT ); Fri, 20 Jun 2014 03:41:55 -0400 Message-ID: <1403250112.22857.7.camel@x220> Subject: Re: [PATCH v5 01/15] thunderbolt: Add initial cactus ridge NHI support From: Paul Bolle To: Andreas Noever Cc: linux-kernel@vger.kernel.org, Matthew Garrett , Greg KH , Bjorn Helgaas , linux-pci@vger.kernel.org Date: Fri, 20 Jun 2014 09:41:52 +0200 In-Reply-To: <1401825852-4745-2-git-send-email-andreas.noever@gmail.com> References: <1401825852-4745-1-git-send-email-andreas.noever@gmail.com> <1401825852-4745-2-git-send-email-andreas.noever@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, 2014-06-03 at 22:03 +0200, Andreas Noever wrote: > Thunderbolt hotplug is supposed to be handled by the firmware. But Apple > decided to implement thunderbolt at the operating system level. The > firmare only initializes thunderbolt devices that are present at boot > time. This driver enables hotplug of thunderbolt of non-chained > thunderbolt devices on Apple systems with a cactus ridge controller. > > This first patch adds the Kconfig file as well the parts of the driver > which talk directly to the hardware (that is pci device setup, interrupt > handling and RX/TX ring management). > > Signed-off-by: Andreas Noever > --- This patch landed in today's linux-next (next-20140620). > [...] > --- /dev/null > +++ b/drivers/thunderbolt/Kconfig > @@ -0,0 +1,12 @@ > +menuconfig THUNDERBOLT > + tristate "Thunderbolt support for Apple devices" > + default no That should have been "default n". But "n" is the default anyway, so I'd say this line might as well be dropped. Should I draft the trivial patch to do that? > + help > + Cactus Ridge Thunderbolt Controller driver > + This driver is required if you want to hotplug Thunderbolt devices on > + Apple hardware. > + > + Device chaining is currently not supported. > + > + To compile this driver a module, choose M here. The module will be > + called thunderbolt. (Naive question: is Thunderbolt relevant outside x86_64?) Paul Bolle