From: Vidya Sagar <vidyas@nvidia.com>
To: <bhelgaas@google.com>, <rjw@sisk.pl>,
<nagananda.chumbalkar@hp.com>, <thierry.reding@gmail.com>,
<swarren@nvidia.com>, <kthota@nvidia.com>,
<linux-pci@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Vidya Sagar <vidyas@nvidia.com>
Subject: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode
Date: Tue, 1 Jul 2014 12:46:18 +0530 [thread overview]
Message-ID: <1404198978-26593-1-git-send-email-vidyas@nvidia.com> (raw)
commit 1a680b7c moved pcie_aspm_powersave_config_link() out of
pci_raw_set_power_state() to pci_set_power_state() which would enable
ASPM. But, with commit db288c9c, which re-introduced the following check
./drivers/pci/pci.c: pci_set_power_state()
+ /* Check if we're already there */
+ if (dev->current_state == state)
+ return 0;
in pci_set_power_state(), call to pcie_aspm_powersave_config_link() is never
made leaving ASPM broken.
Fix it by not returning from when the above condition is true, rather, jump to
ASPM configuration code and exit from there eventually.
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
drivers/pci/pci.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 1c8592b..ded24c4 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -804,7 +804,7 @@ EXPORT_SYMBOL_GPL(__pci_complete_power_transition);
*/
int pci_set_power_state(struct pci_dev *dev, pci_power_t state)
{
- int error;
+ int error = 0;
/* bound the state we're entering */
if (state > PCI_D3cold)
@@ -821,7 +821,7 @@ int pci_set_power_state(struct pci_dev *dev, pci_power_t state)
/* Check if we're already there */
if (dev->current_state == state)
- return 0;
+ goto config_aspm;
__pci_start_power_transition(dev, state);
@@ -839,6 +839,8 @@ int pci_set_power_state(struct pci_dev *dev, pci_power_t state)
if (!__pci_complete_power_transition(dev, state))
error = 0;
+
+config_aspm:
/*
* When aspm_policy is "powersave" this call ensures
* that ASPM is configured.
--
1.8.1.5
next reply other threads:[~2014-07-01 7:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 7:16 Vidya Sagar [this message]
2014-07-01 15:04 ` [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode Stephen Warren
2014-07-02 4:23 ` Vidya Sagar
2014-07-05 18:57 ` Bjorn Helgaas
2014-07-05 19:02 ` Bjorn Helgaas
2014-07-07 16:02 ` Matthew Garrett
2014-07-07 18:00 ` Vidya Sagar
2014-07-07 21:12 ` Bjorn Helgaas
2014-07-08 5:07 ` Vidya Sagar
2014-07-09 18:20 ` vidya sagar
2014-07-11 22:44 ` Bjorn Helgaas
2014-07-14 4:35 ` vidya sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404198978-26593-1-git-send-email-vidyas@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nagananda.chumbalkar@hp.com \
--cc=rjw@sisk.pl \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).