From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: linux-pci@vger.kernel.org
Cc: amirv@mellanox.com, alex.williamson@redhat.com,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: [PATCH v2] PCI: Mark broken INTx masking for Mellanox devices
Date: Fri, 1 Aug 2014 14:54:31 +1000 [thread overview]
Message-ID: <1406868871-350-1-git-send-email-gwshan@linux.vnet.ibm.com> (raw)
The VFIO driver is routing LSI interrupts by capturing, masking,
and then delivering. When passing though Mallanox adapters from
host to guest, interrupt storm was reported from host and guest.
That's because we can't mask the LSI interrupt with help of PCI
command register.
[root@ncc-1701 ~]# lspci | grep Mellanox
0001:05:00.0 Ethernet controller: Mellanox Technologies MT27500 \
Family [ConnectX-3]
0005:01:00.0 Ethernet controller: Mellanox Technologies MT26448 \
[ConnectX EN 10GigE, PCIe 2.0 5GT/s] (rev b0)
The patch marks broken INTx masking for Mellanox devices so that
the VFIO driver will always mask the interrupt from interrupt
controller side to avoid interrupt storm.
Cc: Amir Vadai <amirv@mellanox.com>
Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
drivers/pci/quirks.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index d0f6926..8c2b96f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2977,6 +2977,10 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CHELSIO, 0x0030,
quirk_broken_intx_masking);
DECLARE_PCI_FIXUP_HEADER(0x1814, 0x0601, /* Ralink RT2800 802.11n PCI */
quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MELLANOX, 0x1003,
+ quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MELLANOX, 0x6750,
+ quirk_broken_intx_masking);
/*
* Realtek RTL8169 PCI Gigabit Ethernet Controller (rev 10)
* Subsystem: Realtek RTL8169/8110 Family PCI Gigabit Ethernet NIC
--
1.8.3.2
next reply other threads:[~2014-08-01 4:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 4:54 Gavin Shan [this message]
2014-08-03 7:51 ` [PATCH v2] PCI: Mark broken INTx masking for Mellanox devices Amir Vadai
2014-08-03 8:20 ` Gavin Shan
2014-08-03 8:57 ` Eli Cohen
2014-08-03 14:30 ` Gavin Shan
2014-08-03 15:08 ` Alex Williamson
2014-08-04 0:34 ` Gavin Shan
2014-08-07 3:09 ` Gavin Shan
2014-08-11 13:48 ` Wei Yang
2014-08-12 3:52 ` Gavin Shan
2014-08-12 7:51 ` Amir Vadai
2014-08-12 8:57 ` Gavin Shan
2014-08-12 9:04 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406868871-350-1-git-send-email-gwshan@linux.vnet.ibm.com \
--to=gwshan@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=amirv@mellanox.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).