linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Grant Likely <grant.likely@linaro.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Luck <tony.luck@intel.com>, Joerg Roedel <joro@8bytes.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [RFC v1 26/28] x86, irq: Kill function apic_set_affinity()
Date: Fri, 26 Sep 2014 22:57:56 +0800	[thread overview]
Message-ID: <1411743478-31435-27-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1411743478-31435-1-git-send-email-jiang.liu@linux.intel.com>

Now there's no user of apic_set_affinity(), so kill it.
Also rename vector_set_affinity() to apic_set_affinity() for consistency.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 arch/x86/include/asm/hw_irq.h |    2 --
 arch/x86/kernel/apic/vector.c |   40 +++-------------------------------------
 2 files changed, 3 insertions(+), 39 deletions(-)

diff --git a/arch/x86/include/asm/hw_irq.h b/arch/x86/include/asm/hw_irq.h
index fdf8300dcc29..6c6002e386d4 100644
--- a/arch/x86/include/asm/hw_irq.h
+++ b/arch/x86/include/asm/hw_irq.h
@@ -185,8 +185,6 @@ extern void send_cleanup_vector(struct irq_cfg *);
 extern void irq_complete_move(struct irq_cfg *cfg);
 
 extern void apic_ack_edge(struct irq_data *data);
-extern int apic_set_affinity(struct irq_data *data, const struct cpumask *mask,
-			     unsigned int *dest_id);
 #else	/*  CONFIG_X86_LOCAL_APIC */
 static inline void lock_vector_lock(void) {}
 static inline void unlock_vector_lock(void) {}
diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index ec2b991884f2..01311ddec2de 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -457,42 +457,8 @@ void apic_ack_edge(struct irq_data *data)
 	ack_APIC_irq();
 }
 
-/*
- * Either sets data->affinity to a valid value, and returns
- * ->cpu_mask_to_apicid of that in dest_id, or returns -1 and
- * leaves data->affinity untouched.
- */
-int apic_set_affinity(struct irq_data *data, const struct cpumask *mask,
-		      unsigned int *dest_id)
-{
-	struct irq_cfg *cfg = irqd_cfg(data);
-	unsigned int irq = data->irq;
-	int err;
-
-	if (!config_enabled(CONFIG_SMP))
-		return -EPERM;
-
-	if (!cpumask_intersects(mask, cpu_online_mask))
-		return -EINVAL;
-
-	err = assign_irq_vector(irq, cfg, mask);
-	if (err)
-		return err;
-
-	err = apic->cpu_mask_to_apicid_and(mask, cfg->domain, dest_id);
-	if (err) {
-		if (assign_irq_vector(irq, cfg, data->affinity))
-			pr_err("Failed to recover vector for irq %d\n", irq);
-		return err;
-	}
-
-	cpumask_copy(data->affinity, mask);
-
-	return 0;
-}
-
-static int vector_set_affinity(struct irq_data *irq_data,
-			       const struct cpumask *dest, bool force)
+static int apic_set_affinity(struct irq_data *irq_data,
+			     const struct cpumask *dest, bool force)
 {
 	int err;
 	int irq = irq_data->irq;
@@ -518,7 +484,7 @@ static int vector_set_affinity(struct irq_data *irq_data,
 
 static struct irq_chip vector_chip = {
 	.irq_ack = apic_ack_edge,
-	.irq_set_affinity = vector_set_affinity,
+	.irq_set_affinity = apic_set_affinity,
 	.irq_retrigger = apic_retrigger_irq,
 };
 
-- 
1.7.10.4


  parent reply	other threads:[~2014-09-26 14:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 14:57 [RFC Part3 v1 00/28] Enable hierarchy irqdomian on x86 platforms Jiang Liu
2014-09-26 14:57 ` [RFC v1 01/28] x86, irq: Kill unused setup_timer_IRQ0_pin() Jiang Liu
2014-10-09  2:16   ` Jiang Liu
2014-09-26 14:57 ` [RFC v1 02/28] x86, irq: Prepare IOAPIC interfaces to support hierarchy irqdomain Jiang Liu
2014-09-26 14:57 ` [RFC v1 03/28] x86, irq: Implement callbacks to enable hierarchy irqdomain on IOAPICs Jiang Liu
2014-09-26 14:57 ` [RFC v1 04/28] x86, irq: Refine the way to allocate irq_cfg for legacy IRQs Jiang Liu
2014-09-26 14:57 ` [RFC v1 05/28] x86, irq: Convert IOAPIC to use hierarchy irqdomain interfaces Jiang Liu
2014-09-26 14:57 ` [RFC v1 06/28] x86, irq: Kill unused old IOAPIC " Jiang Liu
2014-09-26 14:57 ` [RFC v1 07/28] x86, irq: Kill x86_io_apic_ops.print_entries and related interfaces Jiang Liu
2014-09-26 14:57 ` [RFC v1 08/28] x86, irq: Kill x86_io_apic_ops.setup_entry " Jiang Liu
2014-09-26 14:57 ` [RFC v1 09/28] x86, irq: Kill x86_io_apic_ops.set_affinity " Jiang Liu
2014-09-26 14:57 ` [RFC v1 10/28] x86, irq: Kill x86_io_apic_ops.eoi_ioapic_pin " Jiang Liu
2014-09-26 14:57 ` [RFC v1 11/28] x86, irq: Kill GENERIC_IRQ_LEGACY_ALLOC_HWIRQ Jiang Liu
2014-09-26 14:57 ` [RFC v1 12/28] x86: Clean up unused forward declarations in x86_init.h Jiang Liu
2014-09-26 14:57 ` [RFC v1 13/28] x86: irq_remapping: Clean up unsued code Jiang Liu
2014-09-26 14:57 ` [RFC v1 14/28] iommu/vt-d: " Jiang Liu
2014-09-26 14:57 ` [RFC v1 15/28] iommu/amd: " Jiang Liu
2014-09-26 14:57 ` [RFC v1 16/28] x86: irq_remapping: Clean up unused interfaces Jiang Liu
2014-09-26 14:57 ` [RFC v1 17/28] x86, irq: Kill irq_cfg.irq_remapped Jiang Liu
2014-09-26 14:57 ` [RFC v1 18/28] iommu/vt-d: Move struct irq_2_iommu into intel_irq_remapping.c Jiang Liu
2014-09-26 14:57 ` [RFC v1 19/28] iommu/amd: Move struct irq_2_irte into amd_iommu.c Jiang Liu
2014-09-26 14:57 ` [RFC v1 20/28] x86, irq: Move irq_cfg.irq_2_pin into io_apic.c Jiang Liu
2014-09-26 14:57 ` [RFC v1 21/28] x86, irq: Kill struct io_apic_irq_attr Jiang Liu
2014-09-26 14:57 ` [RFC v1 22/28] x86, irq: Kill x86_io_apic_ops.write and x86_io_apic_ops.modify Jiang Liu
2014-09-26 14:57 ` [RFC v1 23/28] x86, irq: Clean up io_apic.h Jiang Liu
2014-09-26 14:57 ` [RFC v1 24/28] x86, irq: Kill unused alloc_irq_and_cfg_at() Jiang Liu
2014-09-26 14:57 ` [RFC v1 25/28] x86, irq: Change functions only used in vector.c as static Jiang Liu
2014-09-26 14:57 ` Jiang Liu [this message]
2014-09-26 14:57 ` [RFC v1 27/28] x86, irq: Introduce mechanism to support different vector allocation policies Jiang Liu
2014-09-26 14:57 ` [RFC v1 28/28] x86, irq: Add kernel parameter vector_alloc to set CPU vector allocation policy Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411743478-31435-27-git-send-email-jiang.liu@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).