From: "Li, Zhen-Hua" <zhen-hual@hp.com>
To: <dwmw2@infradead.org>, <indou.takao@jp.fujitsu.com>,
<bhe@redhat.com>, <joro@8bytes.org>, <vgoyal@redhat.com>,
<dyoung@redhat.com>
Cc: <iommu@lists.linux-foundation.org>, <kexec@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<alex.williamson@redhat.com>, <ddutile@redhat.com>,
<ishii.hironobu@jp.fujitsu.com>, <bhelgaas@google.com>,
<doug.hatch@hp.com>, <jerry.hoemann@hp.com>, <tom.vaden@hp.com>,
<li.zhang6@hp.com>, <lisa.mitchell@hp.com>,
"Li, Zhen-Hua" <zhen-hual@hp.com>
Subject: [PATCH 1/5] iommu/vt-d: Update iommu_attach_domain() and its callers
Date: Tue, 21 Oct 2014 16:04:15 +0800 [thread overview]
Message-ID: <1413878659-1383-2-git-send-email-zhen-hual@hp.com> (raw)
In-Reply-To: <1413878659-1383-1-git-send-email-zhen-hual@hp.com>
Allow specification of the domain-id for the new domain.
This patch only adds the 'did' parameter to iommu_attach_domain()
and modifies all of its callers to specify the default value of -1
which says "no did specified, allocate a new one".
This is no functional change from current behaviour -- just enables
a functional change to be made in a later patch.
Bill Sumner:
Original version.
Li, Zhenhua:
Minor change, add change to function __iommu_attach_domain.
Signed-off-by: Bill Sumner
Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
---
drivers/iommu/intel-iommu.c | 32 +++++++++++++++++++-------------
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index a27d6cb..1c7350d 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1531,31 +1531,36 @@ static struct dmar_domain *alloc_domain(int flags)
}
static int __iommu_attach_domain(struct dmar_domain *domain,
- struct intel_iommu *iommu)
+ struct intel_iommu *iommu,
+ int domain_number)
{
int num;
unsigned long ndomains;
ndomains = cap_ndoms(iommu->cap);
- num = find_first_zero_bit(iommu->domain_ids, ndomains);
- if (num < ndomains) {
- set_bit(num, iommu->domain_ids);
- iommu->domains[num] = domain;
- } else {
- num = -ENOSPC;
- }
+ if (domain_number < 0) {
+ num = find_first_zero_bit(iommu->domain_ids, ndomains);
+ if (num < ndomains) {
+ set_bit(num, iommu->domain_ids);
+ iommu->domains[num] = domain;
+ } else {
+ num = -ENOSPC;
+ }
+ } else
+ num = domain_number;
return num;
}
static int iommu_attach_domain(struct dmar_domain *domain,
- struct intel_iommu *iommu)
+ struct intel_iommu *iommu,
+ int domain_number)
{
int num;
unsigned long flags;
spin_lock_irqsave(&iommu->lock, flags);
- num = __iommu_attach_domain(domain, iommu);
+ num = __iommu_attach_domain(domain, iommu, domain_number);
spin_unlock_irqrestore(&iommu->lock, flags);
if (num < 0)
pr_err("IOMMU: no free domain ids\n");
@@ -1574,7 +1579,7 @@ static int iommu_attach_vm_domain(struct dmar_domain *domain,
if (iommu->domains[num] == domain)
return num;
- return __iommu_attach_domain(domain, iommu);
+ return __iommu_attach_domain(domain, iommu, -1);
}
static void iommu_detach_domain(struct dmar_domain *domain,
@@ -2230,6 +2235,7 @@ static struct dmar_domain *get_domain_for_dev(struct device *dev, int gaw)
u16 dma_alias;
unsigned long flags;
u8 bus, devfn;
+ int did = -1; /* Default to "no domain_id supplied" */
domain = find_domain(dev);
if (domain)
@@ -2263,7 +2269,7 @@ static struct dmar_domain *get_domain_for_dev(struct device *dev, int gaw)
domain = alloc_domain(0);
if (!domain)
return NULL;
- domain->id = iommu_attach_domain(domain, iommu);
+ domain->id = iommu_attach_domain(domain, iommu, did);
if (domain->id < 0) {
free_domain_mem(domain);
return NULL;
@@ -2441,7 +2447,7 @@ static int __init si_domain_init(int hw)
return -EFAULT;
for_each_active_iommu(iommu, drhd) {
- ret = iommu_attach_domain(si_domain, iommu);
+ ret = iommu_attach_domain(si_domain, iommu, -1);
if (ret < 0) {
domain_exit(si_domain);
return -EFAULT;
--
2.0.0-rc0
next prev parent reply other threads:[~2014-10-21 8:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:04 [PATCH 0/5] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO Li, Zhen-Hua
2014-10-21 8:04 ` Li, Zhen-Hua [this message]
2014-10-21 8:04 ` [PATCH 2/5] iommu/vt-d: Items required for kdump Li, Zhen-Hua
2014-10-21 8:04 ` [PATCH 3/5] iommu/vt-d: data types and functions used " Li, Zhen-Hua
2014-10-21 8:04 ` [PATCH 4/5] iommu/vt-d: Add domain-id functions Li, Zhen-Hua
2014-10-21 8:04 ` [PATCH 5/5] iommu/vt-d: enable kdump support in iommu module Li, Zhen-Hua
2014-10-22 10:05 ` [PATCH 0/5] iommu/vt-d: Fix crash dump failure caused by legacy DMA/IO Baoquan He
2014-10-22 10:22 ` Li, Zhen-Hua
2014-10-22 10:27 ` Baoquan He
2014-10-27 7:29 ` Li, ZhenHua
2014-10-27 10:44 ` Baoquan He
2014-11-06 1:31 ` Takao Indoh
2014-11-06 1:35 ` Li, ZhenHua
2014-11-06 1:48 ` Takao Indoh
2014-11-06 2:11 ` Li, ZhenHua
2014-11-06 7:51 ` Takao Indoh
2014-11-06 8:06 ` Li, ZhenHua
2014-11-14 6:27 ` Li, ZhenHua
2014-11-17 13:38 ` Joerg Roedel
2014-12-01 6:31 ` Li, ZhenHua
2014-12-01 12:33 ` Joerg Roedel
2014-12-10 8:46 ` Baoquan He
2014-12-12 2:25 ` Li, ZhenHua
2014-12-12 16:11 ` Joerg Roedel
2014-12-15 9:13 ` Baoquan He
2014-12-15 9:16 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413878659-1383-2-git-send-email-zhen-hual@hp.com \
--to=zhen-hual@hp.com \
--cc=alex.williamson@redhat.com \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=doug.hatch@hp.com \
--cc=dwmw2@infradead.org \
--cc=dyoung@redhat.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=iommu@lists.linux-foundation.org \
--cc=ishii.hironobu@jp.fujitsu.com \
--cc=jerry.hoemann@hp.com \
--cc=joro@8bytes.org \
--cc=kexec@lists.infradead.org \
--cc=li.zhang6@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lisa.mitchell@hp.com \
--cc=tom.vaden@hp.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).