From: Lucas Stach <l.stach@pengutronix.de>
To: Richard Zhu <richard.zhu@freescale.com>
Cc: linux-pci@vger.kernel.org, shawn.guo@freescale.com,
festevam@gmail.com, tharvey@gateworks.com, m-karicheri2@ti.com,
Richard Zhu <r65037@freescale.com>
Subject: Re: [PATCH v8 2/9] PCI: designware: Fix one potential assignment error of cfg start
Date: Tue, 21 Oct 2014 12:27:09 +0200 [thread overview]
Message-ID: <1413887229.2751.4.camel@pengutronix.de> (raw)
In-Reply-To: <1413782724-30795-3-git-send-email-richard.zhu@freescale.com>
Am Montag, den 20.10.2014, 13:25 +0800 schrieb Richard Zhu:
> From: Richard Zhu <r65037@freescale.com>
>
> if va_cfg0_base/va_cfg1_base are initialized by
> designware core, the pp->cfg.start is not initialized
> properly, when IORESOURCE_MEM "config" is represented
> as cfg space resource.
> solution: assign cfg_res->start to pp->cfg.start.
>
> Signed-off-by: Richard Zhu <richard.zhu@freescale.com>
> ---
> drivers/pci/host/pcie-designware.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 8d1c809..e3cd54a 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -472,6 +472,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
> if (cfg_res) {
> pp->config.cfg0_size = resource_size(cfg_res)/2;
> pp->config.cfg1_size = resource_size(cfg_res)/2;
> + pp->cfg.start = cfg_res->start;
> pp->cfg0_base = cfg_res->start;
> pp->cfg1_base = cfg_res->start + pp->config.cfg0_size;
>
I think this patch should not be needed anymore. Please look at commit
ec98e9ab6f24 (PCI: designware: Fix configuration base address when using
'reg') in 3.18-rc1. I think it fixes the same bug, but in a different
way. Can you confirm that this works for you?
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-10-21 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 5:25 [PATCH v8]PCI: imx6: enable pcie on imx6sx sdb and imx6qdl sabreauto Richard Zhu
2014-10-20 5:25 ` [PATCH v8 1/9] PCI: designware: Refine setup_rc and add msi data restore Richard Zhu
2014-10-20 5:25 ` [PATCH v8 2/9] PCI: designware: Fix one potential assignment error of cfg start Richard Zhu
2014-10-21 10:27 ` Lucas Stach [this message]
2014-10-20 5:25 ` [PATCH v8 3/9] ARM: imx6sx: Add imx6sx pcie related gpr bits definitions Richard Zhu
2014-10-20 5:25 ` [PATCH v8 4/9] PCI: imx6: Wait the clocks to stabilize after ref_en Richard Zhu
2014-10-20 5:25 ` [PATCH v8 5/9] PCI: imx6: Add imx6sx pcie support Richard Zhu
2014-10-27 18:24 ` Murali Karicheri
2014-10-31 2:43 ` Richard.Zhu
2014-10-20 5:25 ` [PATCH v8 6/9] ARM: imx6qdl: Enable pcie on imx6qdl sabreauto Richard Zhu
2014-10-20 5:25 ` [PATCH v8 7/9] ARM: imx6: Update dts and binding for imx6sx pcie Richard Zhu
2014-10-20 5:25 ` [PATCH v8 8/9] ARM: imx6sx: Add syscon into gpc dts Richard Zhu
2014-10-20 5:25 ` [PATCH v8 9/9] ARM: imx6sx: Enable pcie on imx6sx sdb board Richard Zhu
2014-10-21 8:18 ` [PATCH v8]PCI: imx6: enable pcie on imx6sx sdb and imx6qdl sabreauto Lucas Stach
2014-10-21 9:54 ` Hong-Xing.Zhu
2014-10-21 15:37 ` Bjorn Helgaas
2014-10-22 2:34 ` Hong-Xing.Zhu
2014-10-22 2:48 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413887229.2751.4.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=r65037@freescale.com \
--cc=richard.zhu@freescale.com \
--cc=shawn.guo@freescale.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).